[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array
- To: devnull+j.granados.samsung.com@xxxxxxxxxx
- From: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
- Date: Mon, 2 Oct 2023 22:45:28 +0100
- Cc: Jason@xxxxxxxxx, airlied@xxxxxxxxx, arnd@xxxxxxxx, clemens@xxxxxxxxxx, daniel@xxxxxxxx, davem@xxxxxxxxxxxxx, decui@xxxxxxxxxxxxx, dgilbert@xxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, dsahern@xxxxxxxxxx, edumazet@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, haiyangz@xxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, j.granados@xxxxxxxxxxx, jani.nikula@xxxxxxxxxxxxxxx, jejb@xxxxxxxxxxxxx, jgg@xxxxxxxx, jgross@xxxxxxxx, jirislaby@xxxxxxxxxx, joonas.lahtinen@xxxxxxxxxxxxxxx, josh@xxxxxxxxxxxxxxxx, keescook@xxxxxxxxxxxx, kuba@xxxxxxxxxx, kys@xxxxxxxxxxxxx, leon@xxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, mcgrof@xxxxxxxxxx, minyard@xxxxxxx, netdev@xxxxxxxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, pabeni@xxxxxxxxxx, phil@xxxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, robinmholt@xxxxxxxxx, rodrigo.vivi@xxxxxxxxx, russell.h.weight@xxxxxxxxx, song@xxxxxxxxxx, sstabellini@xxxxxxxxxx, steve.wahl@xxxxxxx, sudipm.mukherjee@xxxxxxxxx, tvrtko.ursulin@xxxxxxxxxxxxxxx, tytso@xxxxxxx, wei.liu@xxxxxxxxxx, willy@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 04 Oct 2023 13:54:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
> From: Joel Granados <j.granados@xxxxxxxxxxx>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/)
>
> Remove sentinel element from cdrom_table
>
> Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx>
> ---
> drivers/cdrom/cdrom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index cc2839805983..a5e07270e0d4 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3655,7 +3655,6 @@ static struct ctl_table cdrom_table[] = {
> .mode = 0644,
> .proc_handler = cdrom_sysctl_handler
> },
> - { }
> };
> static struct ctl_table_header *cdrom_sysctl_header;
>
>
> --
> 2.30.2
Hi Joel,
Looks good to me, many thanks. I'll send on for inclusion.
Reviewed-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
Regards,
Phil
|