[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrii Chepurnyi <Andrii_Chepurnyi@xxxxxxxx>
- Date: Thu, 5 Oct 2023 08:11:03 +0000
- Accept-language: uk-UA, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M47XiSu+LMFNLzzswY8HLK/UPKHw9wp3v2+upPQdER0=; b=CdVfH6TiITfo71NByUgYKadrTfTVZxLMEHQPqZksvBYXvfIIXn/K71fgNCHtGi+0WZuEycVOAZ8qJJvVUowHZJ4Y0ZwLzcQofWQVCbfh3+UOsDAWw+ADXUt6OhBW8OaDdcLGOLPL6OLAWaPM/gngzKS0M775q0hQ6WKFtn6czAAhm+x6XfWK0JQXlnDAxkwCZ7r+/5c7sH1VqZoo0y3YrD4sRBnYHLqTY/LsipAX9KEkw6JTnELA5tWavroJMpNmE8ORHS/BFSJXovMNgJS2dl+eFnpGG5oyZOdw7kyuTh5Nykm2/ole3Y0ZpEEn/beC96iX1NEfmMPiNMxCLPiuxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7GyDsOS7poCbYQR0TO5yzDiJNHjRk/E/HA7IxfsVz/qH+NUa2W/H+PyFm5SQ9GfvRK+tx/Vz94UWGxpMqqvL76V/OGyaCP/czqHtETYZrPy/YeBUeg40H81i2vm+WeFaVrGAmzl0iWW2MLYd5l0mx1w+kX68QwX4ueXKZ0YH2BlOUbDBKS/5lFKMftny8G3ds62JHMEmpBTnAUaVzZqkmIj6s4bhecz15VrSVPXDfpEgebHtxa0/rfPj3byK0hDovNlzIW9msduXYIdb/p1FmSjkMJk5pX2vP3LvWN1DkiK+B0sgoi6Mk+LljqPQxNHcNeck5BPy60YZQQOE2u7Ow==
- Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, "andrii.chepurnyi82@xxxxxxxxx" <andrii.chepurnyi82@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 05 Oct 2023 08:11:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZ9fw82LZSu4lXwEi+r3jS4xqDm7A4FMmAgAE8lwCAAHUlgIABFHmA
- Thread-topic: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations
Hello,
On 10/4/23 18:41, Julien Grall wrote:
> I was asking a pointer to the code in the Device Emulator (QEMU in your
> case). I am confident the code is correct in U-boot, because when using
> 'w0', the unused bits are meant to be set to zero (per the Arm Arm). But
> I am curious to know why QEMU is not doing it.
QEMU flow in the case of the read operation should be the following:
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/hw/xen/xen-hvm-common.c#L389
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/hw/xen/xen-hvm-common.c#L408
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/hw/xen/xen-hvm-common.c#L309
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/hw/xen/xen-hvm-common.c#L228
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/softmmu/physmem.c#L3002
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/softmmu/physmem.c#L2973
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/softmmu/physmem.c#L2942
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/softmmu/physmem.c#L2926
https://github.com/xen-troops/qemu/blob/v7.0.0-xt/softmmu/physmem.c#L2876
From my understanding, only the quantity of requested bytes is updated.
Best regards,
|
