[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen-netback: use default TX queue size for vifs
- To: linux-kernel@xxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Thu, 5 Oct 2023 16:08:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KigcWsilP0vslTifvYlQ+ld2SeybbtsKM0+KjnKpMRU=; b=JnvrPKB68iUfpWUy2GN7eKkx+ngstiDfVp1p6AizFdu7zYARLFijHV86QoXquzOTzf3HRdpBNCQMwwJBKXtYwiZUgggRCJASK/He2flhpitpC4ZO/rPsfjq9eFZnUu9KwdMazWW+kaJdKI0/qlT2IeSiU7xnFvfZtw3g2p2I4t+Qq4FaCFKff1gDbGybeaassL1q17cwxqY1zltHnXwfjgs0taQoU2Ypq/7lj9O3nfJ0vbbiaq+Q7ofEa4Fp/9bvhvoW7SoDfgofmZ47I3F7b4wz0fmULPgVwAV5bA5oQ5l1KDgK5QT1IO9NJWMTuUKb3rYlI0DMzBaVrqNdgK7SGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSQxKfBr/pRmoXlVFFgRSOu5iK+iotTFQWvT+pB/btllaqNmzp0+fU8131cOuT1p/WdObIENBcqci1T50LwyXvbCW20uzkarQmUntHHWwUxEUB2MOCQanCb2xHHdbt64TBOsNv89UgOlQFj6HzKKABSeHY5jackrBnVT4qTPDwJRrb/2l65C8hG+ixPtS4lUbI/1HZG3d+A8lbf+0j2Y4vPEojK65n+zbzYJQBYwSVLE9iBn1l9Bel55bzo1NJPC9aS7uy9T1OG03dCZJ1hmFIJIeERuchq6RHyr1qDiCtytyIGVpOLIiY9dwzngG1gGRkrolU2hA8LYAS+ChOKEpw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
- Delivery-date: Thu, 05 Oct 2023 14:09:02 +0000
- Ironport-data: A9a23:HdsAyK0uuXaGxn3bZ/bD5ZNxkn2cJEfYwER7XKvMYLTBsI5bpz0En zAfC22FPPzfYWCkKdlwaYS1oRwOvZ+ByNNrTVc/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliOfQAOK6UbaYUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb83uDgNyo4GlD5wRmOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfK1h2x aUYLxsxdj+jmuKXxaKyUNkwiZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kkl0ZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13LOSzXOqCN16+LuQq8J7h3Ke9kMqDkNID1SLjuiH13esRIcKQ 6AT0m90xUQoz2SvT9/gT1i7rWSCsxo0RdVdCas55RuLx66S5ByWbkAbQz8HbN07nMw7Xzon0 hmOhdyBLSRmrbm9WX+bsLCOoluaNSELIGoqaSYaQA4B5Nf/5oc+knrnQ9p+Faeng8HdFjb3z DSH6iM5gt07jtMB3o248ErBjjbqoYLGJiYt7w/aWGON9A51ZIe5IYev7DDz5/ZdMI2ZT1+Op 1AfnMyX9u4KBIuA0ieKRY0lDLyvovqILjDYqVpuBIU6sSSg/Wa5eoJd6y04I11mWu4CdCPlb VH7pwxc/tlQMWGsYKsxZJi+Y/nG1oDlHNXhE/zRMNxHZ8ErcBfdpX8/I0mNw2rqjU4g17klP ouWetqtCnBcDrl7yD2xRKEW1rpDKj0C+F4/jKvTl3yPuYdyrlbOIVvZGDNittwE0Z4=
- Ironport-hdrordr: A9a23:L8kFEK4NPcTZKfYNmQPXwPPXdLJyesId70hD6qkRc20tTiX8ra uTdZsgpHjJYVoqKRIdcKm7WJVoIkmsk6Kdg7N9AV7KZmCP0ldASrsSj7cKqAeQfxEWmNQtsJ uIRJITNDQgNzlHZZeT2meF+4hJ+ra6zJw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Do not set netback interfaces (vifs) default TX queue size to the ring size.
The TX queue size is not related to the ring size, and using the ring size (32)
as the queue size can lead to packet drops. Note the TX side of the vif
interface in the netback domain is the one receiving packets to be injected
to the guest.
Do not explicitly set the TX queue length to any value when creating the
interface, and instead use the system default. Note that the queue length can
also be adjusted at runtime.
Fixes: f942dc2552b8 ('xen network backend driver')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
drivers/net/xen-netback/interface.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/xen-netback/interface.c
b/drivers/net/xen-netback/interface.c
index f3f2c07423a6..fc3bb63b9ac3 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -41,8 +41,6 @@
#include <asm/xen/hypercall.h>
#include <xen/balloon.h>
-#define XENVIF_QUEUE_LENGTH 32
-
/* Number of bytes allowed on the internal guest Rx queue. */
#define XENVIF_RX_QUEUE_BYTES (XEN_NETIF_RX_RING_SIZE/2 * PAGE_SIZE)
@@ -530,8 +528,6 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t
domid,
dev->features = dev->hw_features | NETIF_F_RXCSUM;
dev->ethtool_ops = &xenvif_ethtool_ops;
- dev->tx_queue_len = XENVIF_QUEUE_LENGTH;
-
dev->min_mtu = ETH_MIN_MTU;
dev->max_mtu = ETH_MAX_MTU - VLAN_ETH_HLEN;
--
2.42.0
|
