[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [CRITICAL for 4.18] Re: [PATCH v5 00/10] runstate/time area registration by (guest) physical address
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 6 Oct 2023 10:22:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/FrAqAEqA8Zg1gV/X7uuOcv5wvRyAGYIBHSuHeoVVM=; b=S9uOnxQ0SCkaiVEF473k/w67rnrmqPX+JBo+GNnV9QyAP6vvboJHg7aS0R1d2wlF1AThphHAw/qxWLUA5ikUUB3oLoeOrD+isU0F1mhFOIlh5FWIW6P7RABUTjJQSAeLynYfS6dN7ZIdnjUAeqXPUnuLN6nRU+UP5CaQt74to21/JHuIcfU48Uba6KwUirWebdm/cSZ6qfoPKWruv9T6xCxjo9Rv0nGn2Sqmhgc433Qb/nwwzZzXCgw5/rojBbEqDgnL65sRUzSjoio10y8ZCeX50+WSN6yW3JM4rbIDF9Q+Ps+Iy3Tklva69Bkkx6UxgYJCXnamzKgggsunmggAjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3tt/vl/44/N99sMVA4l0HFfYZU6CLDSwTIKSB9fdONCkS1lCaqNYkgnsjmwqTGroN+pa7Fyq8WQaozg8IP+ZNJYyp72o+HMSMmye12iO2sgZuMpxKnjB2GD+PvsX1o1qLQ+RvQdEkpyk+gE39xaqKbZ2dps2L1qPaXbz1O9PJDagznWh8ySrw9sy3IUIx4k5iU1istbVe2ueXlb3EsQ7Pm22bxdsPOoExKfSLIl5rDwM7RvOYxq8ABc/0e1Q/6MEjnZGoJuWvIKRiWZ0fvF67zda/GkCN165vXTJ1eoayGlDZnVwj1vgKZ6OlodEiDIjrA83IDqOefUOkBosvR2cQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, henry.wang@xxxxxxx, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 06 Oct 2023 08:22:56 +0000
- Ironport-data: A9a23:v+bWmaj21ZWeF460AAiqJetmX161kBEKZh0ujC45NGQN5FlHY01je htvXWyPOP6NZGXzftt2Oo628B9T65+BzNBmTwU9/yFhFCIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOhTraCYmYoHVMMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyp0N8klgZmP6sS5AeDzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQnJigGT0iyntiu647rQNtrqcJkNsfCadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGyabI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqhBNpPROfiqZaGhnW3730uMkMKfGKKrMedlH6OV5VwD HULr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtMIwXy1sy VaPkPvgHzkpu7qQIVqB/7KdthuuOiwYK2ATaCtCRgwAi/HhqowuihPETv54DbW4yNbyHFnY3 DSivCU4wbIJgqYj1bi//F3BqyKhoN7OVAFdzh7MQmuv4wd9ZYikT4+l817W6bBHNonxc7Wal H0Nmszb5uZeC5iIzXaJWL9UQ+jv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf XPuhO+Y37cLVFPCUEO9S9vsYyj25cAMzejYa80=
- Ironport-hdrordr: A9a23:J+sHkaqsxWi9htqjiOBEJLMaV5tMLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qhoPRPAh3Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzSIwxsEVDtL4LE6tU zIiRbw6KmPu+yyjka07R6f071m3P/ajvdTDs2FjcYYbh3qlwaTfYxkH5GSoTwvp+mryVAy1P 3BuQ0pMchf427YOku1vRzu8Q/91ytG0Q6p9XaoxV/Y5eDpTjMzDMRMwapfbxvi8kIl+PVxyr hC0W61v4deSUqoplW32/H4EzVR0makq3srluAey1RZTIslcbdU6agS5llcHpssFD/zrKonDO 5tJsfB4+s+SyLTU1np+k1UhPC8VHU6GRmLBmAEp8yuyjBT2Et0ykMJrfZv6ksoxdYYcd1p9u 7EOqNnmPVlVckNd59wA+8HXI+eFnHNaQikChPSHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8JfV70A8Hm5uwEzvn0ehT/Yd3R8LAd23Ag0YeMAYYDcBfzB2zGqvHQ48n2WabgKr KO0JE/OY6XEYKhI/cP4+TEYegjFZAvarxqhj8FYSP+nivqEPycigWJSoekGJPdVRAZZ0jYPl wvGBDOGeQo1DHYZpa/ummcZ0/Q
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 06, 2023 at 10:00:35AM +0200, Roger Pau Monné wrote:
> On Thu, Oct 05, 2023 at 07:58:50PM +0100, Andrew Cooper wrote:
> > I see this series has been committed. But it's broken in a really
> > fundamental way.
> >
> >
> > This is a new extension with persistent side effects to an existing part
> > of the guest ABI.
>
> The only change in the ABI is the different return code for multiple
> attempts to map the vcpu_info page, it used to be -EINVAL and it's
> -EBUSY now, which seems more descriptive.
>
> The added hypercalls are an extension of the ABI, not not a
> modification of an existing part. Or maybe I'm not understanding the
> complaint.
>
> > Yet there doesn't appear to be any enumeration that the interface is
> > available to begin with. Requiring the guest to probe subops, and
> > having no way to disable it on a per-domain basis is unacceptable,
>
> We have never mandated such disables to be part of the series adding
> the new hypercalls, those have always been retro fitted in case of
> need. Not saying we shouldn't do it, but it's not something we have
> asked submitters to do.
I've been thinking about this, and I assume that we would like some
kind of tools interface to list supported features by the hypervisor,
and then a way to disable them. We could then use such information to
level the hypercall interface across a pool of hosts, and make sure
it's always the same.
In principle guest should cope with some features/hypercalls not being
able on resume, but we all know this is not always the case.
I'm going to punt this, as adding such interface would be too
disruptive at this point in the release, and in any case it's
unlikely we could reach an agreement on how the interface should look
like in a very short time frame.
Roger.
|
