[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] domain: expose newly introduced hypercalls as XENFEAT
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 6 Oct 2023 13:29:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbitnJdJhcnjzK3oKZpTNzJ1d7duMx6lCRu/MBrQgi8=; b=KcQQYZmAYW9sBkHFPSR7oFdxGtfNfzLOaPF8CN65cRPiH0/IFO6T72V8fURdlf3HeDxy1fdPh27B0hN7bEe46/5byqFizCb63LrxVV5T5Q5u+S/XI2kvxoRv9RHEQV3m5zG6n9Q3TVCjX6t/0Qxu/k3O5TLF0RYFqmj45MJ28WE2p2NdfQ8WPHjvuintAgTrfeI9bdSAv91KVDoqPJWZnLiNzrRFHdm1jOCsXii9e/wQhf1mDKt3V7fWhUOuWYJyxjPNC355bF2vkSfuC5/EBbs97V2FT3STfRbPZrOWM2W5RZkM2391C2uH4mIXckKrRzx8PmgcZB9E8jCFY6yorA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FlZ+fM6dtyZ3VRNH7u2T6nWacAPgl3+xT6YiuuufLF0x6v+s9FSR+5kP4sTLUMmMBxUc5+3xxYvApI75znKxiFqfFthTa6fN+HqvJiT0SjORwunDw8FjGSHpo2/0XoI7LG7xfjO9MOFGDPu41k/xq1nWT86FdTkGg/689s8kMcE9tBfBmzxVQEpOabZvCZrQfzNaXafnM4CduarnE2YfSLUDK3aWD+X8aXYYUZHoAu6eZPMFqYmVYNfxO4kAYkJUoVnK717/MzxZ627VBYgNvqjGieVknQnjI28TsYxY1oGp/UbTP0iuVtXjHhKcD40Cv1HSwnHQzV1vGoDqg/sZ4w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 06 Oct 2023 11:29:30 +0000
- Ironport-data: A9a23:FeGfVqDUaLsEPBVW/63iw5YqxClBgxIJ4kV8jS/XYbTApDomgzwOm 2VJD2jVO62NMWKjcot0Ydi38UxUvp/VxtZjQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48D8kk/nOH+KgYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsMpvlDs15K6p4WtA4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpL0nOW1/5 KIkLWo/NCiN2u3r4oy/c7w57igjBJGD0II3nFhFlGucIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9OxuvDK7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLcqC3x1rWSwnKTtIQ6CLao7/l3hAav108tGSQJcFmHhfqyhRvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkgJSCRQLuMvssAeTCYvk FSOmrvBDjtqtaCTSG6MsLKdqzq9NDI9PWIEfTUDTwYO/5/kuo5bphDFQ8tnEaW1psboAjy2y DePxAA8mrESgMgjx6i9u1fdjFqEvYPVRwQ44gHWWGON7Q5jYoOhIYuy5jDz8vJoPIufCF6bs xA5d9O26ekPCdSBkXKLSeBURrWxva/aanvbnEJlGIQn+3K14Xm/cItM4TZ4YkB0LsIDfjyva 0jW0e9M2KJu0LKRRfcfS+qM5w4ClMAMyfyNuijoU+dz
- Ironport-hdrordr: A9a23:WZ/yiq0Ubkai/8lMr4alvwqjBAMkLtp133Aq2lEZdPWaSK2lfq eV7ZAmPH7P+VMssRQb8+xoV5PsfZqxz/JICWd4B8bZYOCkghrSEGlahbGSvgEIYheOitK1t5 0BT0EOMqyTMbEgt7ec3ODQKb9Jq+VvlprGuQ609QYPcegFUc9dBi5Ce3mmO3wzaglaJIYzUK GR7tBAoFObCAwqR/X+KHkZfvTJ4+bGnpL+YRIAGnccmXCzpALtxr7mMgSSmiwTWTNXwbsk7C zsngHj6r+42svLuyP05iv874l2hNCk8NdFCcCW4/JlTAnEhwqzeYRnU6CDujcuydvflmoXrA ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 06, 2023 at 12:19:29PM +0100, Andrew Cooper wrote:
> On 06/10/2023 12:02 pm, Roger Pau Monné wrote:
> > On Fri, Oct 06, 2023 at 11:47:48AM +0100, Andrew Cooper wrote:
> >> diff --git a/xen/common/domain.c b/xen/common/domain.c
> >> index b8281d7cff9d..df994bd30fd2 100644
> >> --- a/xen/common/domain.c
> >> +++ b/xen/common/domain.c
> >> @@ -1998,6 +1998,10 @@ long common_vcpu_op(int cmd, struct vcpu *v
> >> {
> >> struct vcpu_register_runstate_memory_area area;
> >>
> >> + rc = -ENOSYS;
> >> + if ( 0 /* TODO: Dom's XENFEAT_runstate_phys_area setting */ )
> >> + break;
> >> +
> >> rc = -EFAULT;
> >> if ( copy_from_guest(&area.addr.p, arg, 1) )
> >> break;
> >>
> >> and a matching one for XENFEAT_vcpu_time_phys_area because I'm even more
> >> serious about this becoming a domain controllable setting following what
> >> OSSTest had to say overnight.
> > While this is all fine, please note that the newly added code
> > {,un}map_guest_area() is also used by the existing
> > VCPUOP_register_vcpu_info hypercall, and that one can't be disabled.
>
> Yeah, I'm aware we're stuck there, but a crap interface from the past is
> not an excuse not to do new interfaces properly.
Right, want I intended to say is that if we are worried the new
{,un}map_guest_area() might be buggy, and would like to have a way to
disable it, just preventing usage of
VCPUOP_register_{runstate,vcpu_info}_phys_area won't be enough as the
newly introduced function is also used by the existing
VCPUOP_register_vcpu_info.
Not that we shouldn't add the checks, just that those won't cover all
usages of {,un}map_guest_area().
Thanks, Roger.
|
