[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] domain: expose newly introduced hypercalls as XENFEAT
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 6 Oct 2023 15:19:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TvZGn6ffIlfllwxjj9VeANjGXEPjnVFMRzYwixlHsZM=; b=GhPY3AVaW/iO79KvgRFh7vu0xTw9kcBDwlyHWhw5f6ifPshDJzrWDTF1ywirjXjbJi0S79AdWUJxbJTYWKTeUPDOgm1px7TdyqF6gC3TbCd5oGX2oU7BjGnWc0YoZzttD6njDM/gZdksB/s4K2IovucJsk9HukgMgSBa4aHF/YwOE3dsunuDQbKfNf2jn78CuGE6fR1d/6dN6sap+jX1cYlDX61HiVEbvg0aXngWoZ4xvAERmc5ONFHGS24IvN0Z3isMkZfH811oTjf445hzZ5f6k4v8QpkfW8K/gHr9HzKF6griXyQviZ5QFYEfPfolFPf7GIIIxJYv5UmLse3vwA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sz1U1lOHonOSwfMcjhJHxIsuwI7PmIGj/umkGA3esy3xorREEK1kgyq+ZDujyf+xzcXhDVEoPD+HeHZjKn0CTgj2lMP2TNDwL7xBN8yzX2AD/zQgC87Abe4s/MqZGcluVwG/1j1hB/Sh2XM1210Ywpr78K54RKkr5gDJxOj68jQejND7JIfw5+1QajkIDShSG4bKgoDNkiWD74BUEARKbxgxkES4JSwj8qKwnqJrTbcL2GKvHNIeKgncJNBUHbCYynvoCsiPvhZUBjZFtxGeI37ob84+08okkzfvE9oetdAG2VLQFeXxjMUVJJnL0b8fXApvY2Y89t5ykX951r3fAQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 06 Oct 2023 13:20:13 +0000
- Ironport-data: A9a23:bIfSiKLX7rMHlzcPFE+RVZQlxSXFcZb7ZxGr2PjKsXjdYENShTUOn WVNWWGGOqmKNGP2coxxa960p0lT6p/VzdM3QVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAhk/nOHvylULKs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrYwP9TlK6q4mhB5gRgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5TGUgSp aISdApdaw3fiqXn2Z2jVrdF05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLl2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv22refx3qnAur+EpW+5PN7gWaKw1ZJIwIdcmqmvseWrX+HDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz FrPlNTsbRRkt7iQVHSc6qbSqDq0MCcYN0cSaCkcVwwH7tL/5oYpgXrnTNxuDaq0hd3dAizrz naBqy1Wr7cOic8G0Y2r8FaBhCijzrDSVRI87AjTWmOj7yt6aZSjaoju7kLUhd5fKK6JQ1/Hu 2IL8/Vy98gLBJCJ0SCIHuMEGejx4+7faWWHx1lyA5Mm6jKhvWa5epxd6y1/I0EvNdsYfTjuY wnYvgY5CIJvAUZGpJRfO+qZY/nGB4C5fTg5fpg4tuZzX6U=
- Ironport-hdrordr: A9a23:Fmp46KlshJA+wG30XIt+OHBJcafpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 06, 2023 at 02:05:18PM +0100, Andrew Cooper wrote:
> On 06/10/2023 2:00 pm, Roger Pau Monne wrote:
> > diff --git a/xen/include/public/features.h b/xen/include/public/features.h
> > index d2a9175aae67..22713a51b520 100644
> > --- a/xen/include/public/features.h
> > +++ b/xen/include/public/features.h
> > @@ -111,6 +111,15 @@
> > #define XENFEAT_not_direct_mapped 16
> > #define XENFEAT_direct_mapped 17
> >
> > +/*
> > + * Signal whether the domain is permitted to use the following hypercalls:
> > + *
> > + * VCPUOP_register_runstate_phys_area
> > + * VCPUOP_register_vcpu_time_phys_area
> > + */
> > +#define XENFEAT_runstate_phys_area 18
> > +#define XENFEAT_vcpu_time_phys_area 19
> > +
> > #define XENFEAT_NR_SUBMAPS 1
> >
> > #endif /* __XEN_PUBLIC_FEATURES_H__ */
> > diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
> > index 8fb0bd1b6c03..03b031a3e557 100644
> > --- a/xen/include/public/vcpu.h
> > +++ b/xen/include/public/vcpu.h
> > @@ -236,6 +236,9 @@
> > DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t);
> > * Note that the area registered via VCPUOP_register_runstate_memory_area
> > will
> > * be updated in the same manner as the one registered via virtual address
> > PLUS
> > * VMASST_TYPE_runstate_update_flag engaged by the domain.
> > + *
> > + * XENFEAT_{runstate,vcpu_time}_phys_area feature bits signal if the
> > domain is
> > + * permitted the usage of the hypercalls.
> > */
> > #define VCPUOP_register_runstate_phys_area 14
> > #define VCPUOP_register_vcpu_time_phys_area 15
>
> For both of these, I'd suggest s/permitted/able/. For older versions of
> Xen which don't advertise the XENFEAT, it's a matter of capability, not
> permission.
>
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> and
> I'm happy to adjust on commit to save sending out a v3.
TBH I've used permitted because that's the wording you used in your
reply to v1, I'm perfectly fine with switching to able.
https://lore.kernel.org/xen-devel/ac4842a9-7f62-4c64-9a3a-2ec2b1e97699@xxxxxxxxxx/
Thanks, Roger.
|
