[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 6 Oct 2023 14:01:26 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bXKiWVTs0jgY5PR++bLAGykx6oWZ5y3QR/PCTyCwyqk=; b=bu3F9rvCKfObKYVtqBhRc2LtW6xS6GccukUw1Gt6/9kggtDioBzLLAMCHzJUh9j1bfCQIttK/EWgjsNrVgoGHorev1H8fkLfVstWIOQts84NOh5CCtikuxY1KdAZHPXUDAsaRmBRW+x28oBlOCLdJpYU3tpIX3WslygTYX2wljoM8uU3DiHxdKj3ijXkxGjVgwjAsC5CZhhpLhH7iQyzZ0qxyosYf3x1W0xFsyUPaxwpPyJObn4IvlJhEfb+7PVdiUGy2W6EJm7JHgdxClPUkpZeN/4wdhlL1oR1A7/qUrErtXzCUerbKPCEyu3Cyn02HnfbsDRhw7DXNzxlvM7ndw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxPcmWk5g0XXTHjo8QE7x5adUM+8H0GBgFLR52aaadzvjQT/EIMJfVKQfI7X5lftfLmqWc38XaaC78wwNo+eX+lX7daNkMW8gKNPrh/7r9PxKmrlF06XEKCVSYxol9EIK8oqb9fcTyP0bhxXO2rgfRlj/MsEL5rouz/9/Y92gGFw7Q4PzQeAMVlvIqI3Jne/XKwdVOYR9g3mUaQexynnceVpUnzYoxAJJRi1G5Pa3wsnSIgzLdeToKXmZkAqROdanvpUa3qT/3bkQfpGqSkHfewDhqazig5SVIUQGW2GwXYy/T25jMqUC3YP6qxk9bwe3ClayX5Q1Cqgp9p9cYEXUw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Oct 2023 14:01:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ+F0n5Y2AIoSXPky3KIS2scfL57A8ynIA
- Thread-topic: [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings()
Hi Andrew,
> On Oct 6, 2023, at 21:57, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> The last user of this variable was dropped.
>
> Fixes: 295514ff7550 ("common: convert vCPU info area registration")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> CC: Henry Wang <Henry.Wang@xxxxxxx>
>
> I expect Gitlab randconfig to find this eventually, but it does depend on
> CONFIG_MEM_SHARING being active to manifest.
> ---
> xen/arch/x86/mm/mem_sharing.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
> index 5217c755a299..94b6b782ef2e 100644
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -1706,7 +1706,6 @@ static int copy_vcpu_settings(struct domain *cd, const
> struct domain *d)
> {
> unsigned int i;
> int ret = -EINVAL;
> - mfn_t vcpu_info_mfn;
>
> for ( i = 0; i < cd->max_vcpus; i++ )
> {
> --
> 2.30.2
>
|
