[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/xenpvboot: remove as unable to convert to Python 3
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 6 Oct 2023 14:57:12 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRt0gxeNiKlYBfOjGCHbGIkRam60tGaeGXPUfV2ErnU=; b=TaJKr53KvLKS03gpbgaa8g2hS8L3e91Kzz+PKgTgFYdVcSIut48XuoY0VwBEa1lg0FAyEn49/Idk2TIsS1FiNupU1OVD/BIPDvhgoaLkU6jbzhWCW4hkO2wHyJytxQzu+B9tCaA7KsTVtTIKFS9CUPoepW/uIUmVXoRQseJmIPu2EUKl5aCdbG5PZ2YlnVAUuywEn847I5azaY9YxH5drWWcqih1y9e+y+KpCzpE4ue7TfMVQTQSVYyonHqDlQ/qt2bPuLgAk9Kom5wUSQMs7UVKuTdcNHs/FGMuDh61ibehkCqkdFQR7IgYVO3iF3xovuD52CqbNTLGMvUvi9yKTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxkylTd4BXGdNf82pUJCtWJ26DLIeUs68lH32LOPXrNhOrdknptDN0E3wFBtXJyXRUMpbpgLcwnKqfXOHhv/1qn9RAWJqRihVVzaLVGppp7a1GfK5P5NzFiiBzco9hSN4PmFn7kiAGHVOldjaeItY2rnecWSVyitSbr5g5NR6YKRW900G3cw6azvtERVOLtRUQyLIX2CyKrySQMZkXeGJMZ0YNuE8e+Xn0Zs5wJr9321fkf3CZqJEHwsSiKF+kssOc2j+/C8akjh9XXTN4sUHdHlomKbWUKWsIKEECBg/WMeeQrF5nA+gf/XKuJHbqOqKJ+wuyEJ3EveRcIiouRO+g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Oct 2023 14:57:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ+GSuiyqA87xC/k2xl+J2CZcV8bA82XkAgAAAdwA=
- Thread-topic: [PATCH] tools/xenpvboot: remove as unable to convert to Python 3
Hi,
> On Oct 6, 2023, at 22:55, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
>> The script heavily relies on the urlgrabber python module, which doesn't seem
>> to be packaged by all distros, it's missing from newer Debian versions at
>> least.
>>
>> Also the usage of the commands module has been deprecated since Python 2.6,
>> and
>> removed in Python 3, so the code would need to be re-written to not rely on
>> urlgrabber and the commands modules.
>>
>> Arguably the purpose of the xenpvnetboot bootloader can also be achieved with
>> an isolated script that fetches the kernel and ramdisk before attempting to
>> launch the domain, without having to run in libxl context. There are no
>> xl.cfg
>> options consumed by the bootloader apart from the base location and the
>> subpaths of the kernel and ramdisk to fetch.
>>
>> Any interested parties in keeping such functionality are free to submit an
>> updated script that works with Python 3.
>
> Resolves: xen-project/xen#172
>
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Thanks for doing this.
+1
Kind regards,
Henry
>
> ~Andrew
|
