[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 3/5] xen/arm: make has_vpci() depend on d->arch.has_vpci


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • Date: Mon, 9 Oct 2023 15:57:42 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LOZmhrmNckz6NkJakVLSz/H8hX/OOGQLeh4TaQxTWhU=; b=J2KugG39pg7JAxKg+FDYS9NCrP7yR8wxfiWa0dEwSl8iiyyML0apPMbOBN74f0L2pLbLpDCWv8rOacc0d2sq+GaHFaDT3bl/OK5MgK66W/tZ5rcb3xk1P+MG4yuZrdKFSSABN1c31m8rc5hQX6hYqugX3wsCTSyv+rVS3ZP7WGeaQ4mt9eXaCJrKHqHoc3SV1NqzHkH+jWmfUQhJ1Mq6WVUZLn8me7LcqQzgqailNNU3oqJ3HC5aDFa9UYVwFCOXr/QLe36qIMt6eMGrJGlRPYKO3Yavvoa8V9W1sZI7Rw/f7X2KthR9cElSyFnfzv4GHiCsMpIkVUiM94AIvLKyBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJOZwGEsBeE83cSOr9msavyWscOISD6/IPDPwLViRPbZ4Q72d883YDW3ykht2uDR0ZQMjFKSYVAfpqsBK33kG+3sowM9UcKcCrZLjEfUh8b8wueYh6Na4M06zcuauK9tvysJonuNv4RdLkWAHJVj5K3y19bMHlHTSBWTAyZAG0SNXPipSSqLhM+Vewu5LLW65bBV+OKY2HMLRtea+wIV2QZL398byhTSPBmQ5uvYDRpQpjnXMkcb06E0Hc4Y/dzqcvJaXj8THL8Pl8ypdFZp3CvXPGzz7/1/QrwZUdq2cm5St/oJJMOCc5VFKmO1mOooHFt2ccX0NO+K83d6cxBGKQ==
  • Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "Stewart Hildebrand" <stewart.hildebrand@xxxxxxx>
  • Delivery-date: Mon, 09 Oct 2023 19:58:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

VPCI is disabled on ARM. Make it depend on d->arch.has_vpci to enable the PCI
passthrough support on ARM.

While here, remove the comment on the preceding line.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
---
There are two downstreams [1] [2] that have independently made a version this
change, each with different Signed-off-by's. I simply picked one at random for
the Author: field, and added both Signed-off-by lines. Please let me know if
there are any objections.

v2->v3:
* use d->arch.has_vpci since plumbing struct arch_domain with a vPCI flag

v1->v2:
* add is_hardware_domain check. This will need to be removed after the vPCI
  series [3] is merged.

downstream->v1:
* change to IS_ENABLED(CONFIG_HAS_VPCI) instead of hardcoded to true
* remove the comment on the preceding line

[1] 
https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc/-/commit/27be1729ce8128dbe37275ce7946b2fbd2e5a382
[2] 
https://github.com/xen-troops/xen/commit/bf12185e6fb2e31db0d8e6ea9ccd8a02abadec17
[3] https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg02361.html
---
 xen/arch/arm/include/asm/domain.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/arm/include/asm/domain.h 
b/xen/arch/arm/include/asm/domain.h
index 0a66ed09a617..ebba2c25dceb 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -300,8 +300,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
-/* vPCI is not available on Arm */
-#define has_vpci(d)    ({ (void)(d); false; })
+#define has_vpci(d) ( (d)->arch.has_vpci )
 
 struct arch_vcpu_io {
     struct instr_details dabt_instr; /* when the instruction is decoded */
-- 
2.42.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.