[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/4] Introduce %rip-relative addressing to PER_CPU_VAR macro
- To: Uros Bizjak <ubizjak@xxxxxxxxx>
- From: "H. Peter Anvin" <hpa@xxxxxxxxx>
- Date: Thu, 12 Oct 2023 14:21:39 -0700
- Cc: Dave Hansen <dave.hansen@xxxxxxxxx>, x86@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
- Delivery-date: Thu, 12 Oct 2023 21:22:16 +0000
- Dkim-filter: OpenDKIM Filter v2.11.0 mail.zytor.com 39CLLiXS1851702
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/12/23 14:17, Uros Bizjak wrote:
Are you PIC-adjusting the percpu variables as well?
After this patch (and after fixing percpu_stable_op to use "a" operand
modifier on GCC), the only *one* remaining absolute reference to
percpu variable remain in xen-head.S, where:
movq $INIT_PER_CPU_VAR(fixed_percpu_data),%rax
should be changed to use leaq.
All others should then be (%rip)-relative.
I mean, the symbols themselves are relative, not absolute?
-hpa
|