[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: Skip memory nodes if not enabled



Hi Michal,

On Fri, Sep 29, 2023 at 10:11:19AM +0200, Michal Orzel wrote:

[...]

> > +static bool __init device_tree_node_is_available(const void *fdt, int node)
> > +{
> > +    const char *status = fdt_getprop(fdt, node, "status", NULL);
> Please see Julien's comment for v1. To save some jumps,instructions
> we should also check for length of the property to be > 0, just like we do in 
> dt_device_is_available().

Sorry for I missed Julien's comment.  Have sent patch v3 for review.

And apologize for late replying.

Leo



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.