Re: [PATCH v7 5/8] xen/arm: Split MMU-specific setup_mm() and related code out

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 09/10/2023 02:03, Henry Wang wrote:
> setup_mm() is used for Xen to setup memory management subsystem,
> such as boot allocator, direct-mapping, xenheap initialization,
> frametable and static memory pages, at boot time.
>
> We could inherit some components seamlessly for MPU support, such
> as the setup of boot allocator, whilst we need to implement some
> components differently for MPU, such as xenheap, etc. Also, there
> are some components that is specific to MMU only, for example the
> direct-mapping.
>
> Therefore in this commit, we split the MMU-specific setup_mm() and
> related code out. Since arm32 and arm64 have completely different
> setup_mm() implementation, take the opportunity to split the
> arch-specific setup_mm() to arch-specific files, so that we can
> avoid #ifdef. Also, make init_pdx(), init_staticmem_pages(),
> setup_mm(), and populate_boot_allocator() public for future MPU
> implementation.
I am a bit confused with the last sentence. AFAICT, even without the MPU 
work, I think you already need to export init_pdx() & co because it is 
called from two different units.
> With above code movement, mark setup_directmap_mappings() as static
> because the only caller of this function is now in the same file
> with it. Drop the original setup_directmap_mappings() declaration
> and move the in-code comment on top of the declaration on top of
> the function implementation.
>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
With the above comment clarified:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall