[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 2/8] xen/arm: Split MMU system SMP MM bringup code to mmu/smpboot.c
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 13 Oct 2023 23:33:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6i5kopqek43+flfOP6vSbXovs94Nimi6d+tXRm5kAI4=; b=VaeRtV9hAPlOB6NWDfM5VcDN3ACoFj5JJc2rlDP478jd3A6TE21XAJcC/8xHDH2xk8cD2rutPWSQ87JZf02m8DZ52rU6+SBImcvaRzi/EntF5MSA0g8C1FEHeMxvep7yHV77HAc6uy+oaK3VCBqwmuQX5sPX/SvMk3u5jnHpvOxpeB0DofXHZjnj1BSmYFZsF0TRqoWLUUj1mPsw5CUCybJb5ZFj4ojA+hbtNqcZjmBkvsvT1YQzPgIFQcN6hNAQvhxXFQIikemd9yeBOgAIIuU7zO/qb2SC+gW8+YBrk5yE+OCUG8Sycdvsa9xYPKanGM+h85peXPwb/7uSutQn0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UafHbNGR3xUG5giZgugpXbgRLQ0Rz8mRYIKZ/Ztwr1Ky21ZhuFWbnX/NDmkQeMc6sjOGdgTg6qSzBJZYOsfYhP1hojz+7vdS8FojygUVlxjrwvIeohKruGDuKF3dicSy2xc1nSiRoZA/iYJ24KX+MeL9sPpMz4vrQqaHcngXdypavsllxcK+eHjODBQhaZmZFrBVFeIItkHu6U51aPjrOurB9O/V/BQf8TzsO8xHVLXDunZ/u3nSHMy6ieDpaRj+7+8v6Zoltb4fai+Wm+YN4k3fnUIOfMJzMb1VH4j0XVvsogPKsHqWh30ZGQrSKVb/85jNRK3KC+MlKieb2f7wgQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Fri, 13 Oct 2023 23:34:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ+kx0F2v+gIdRRkSLGpfAPDpgbrBH/UYAgABpcYA=
- Thread-topic: [PATCH v7 2/8] xen/arm: Split MMU system SMP MM bringup code to mmu/smpboot.c
Hi Julien,
> On Oct 14, 2023, at 01:16, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 09/10/2023 02:03, Henry Wang wrote:
>> +#ifdef CONFIG_ARM_64
>> +int init_secondary_pagetables(int cpu)
>> +{
>> + clear_boot_pagetables();
>> +
>> + /*
>> + * Set init_ttbr for this CPU coming up. All CPus share a single setof
>> + * pagetables, but rewrite it each time for consistency with 32 bit.
>> + */
>> + init_ttbr = virt_to_maddr((uintptr_t) xen_pgtable);
>
> The cast should be necessary. With this dropped:
Nice catch, my mistake, will change in v8.
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
