[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 6/8] xen/arm: Fold pmap and fixmap into MMU system
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 14 Oct 2023 00:11:13 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJirgkc+PBmwlTGucvBwdTikJ33tgo+Nl/klEuf009k=; b=i4OCpPow5UMg/OSEDldlLAGKXj18+KoSxqE/NRerJUHOG1g7RyOqh3rr3X7kYrSU9sxDEtKQdIAN9u8XKzOUTe1NVN4J62cKUG2ez7fVKRbtugWdG86hu9BrjAFaZY5TypTF3JhAwKgqpazNS2/VYPOCnBWtxAlz9PL/2WIZebXl9tvk5t/yQ5BfmcXHDpCMlT6A9LLbhw4Di0Pny9eeqwjxRikQpiKovHBiL2rKOWwN5LHS3rLks3ujeFqQ3aQm0zj5GqqsQJdn54Er4tX3RziFHsGmWP9VnqQ2Y7yaOO0G3A98PuqjvFwsGZFgEk4oGwRidn185uF49p3SH/Rkkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uhgk2VsqgzTvPv7MR6DkSo9Z3DBLp0bORK8WNPvr2/Ya63LFRGWxEeRMuuX68SCqZrlmW+lD6g5IfINcj8XtDfCO3W2kpKcSkFZj5Vq2mnVmDhtP24mE1+iBw5q2QRBhjPKeP6RxiqmG6xkuAMEhRarQWubz357sVR9HFGUG/2jR6KpgXoJrHvF4pQJQGYfE9ZVMKsInAPcze7WjQcbTnYfBTkf4Z83Vztz3d1q5t5nA110XWkGGC2vMRI0DmXveaDpX2zpOyWzYlF+sF7ofmVcpwsZxb7TgqzCvkI4wWHUrpxpuAvHLYS7UJriJDIF8r2h1MYOG4NRtL4PJ+0UnFw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Sat, 14 Oct 2023 00:11:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ+kx8olLPGtaa90qvzUCne3k+lbBIBR+AgABsGgA=
- Thread-topic: [PATCH v7 6/8] xen/arm: Fold pmap and fixmap into MMU system
Hi Julien,
> On Oct 14, 2023, at 01:44, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 09/10/2023 02:03, Henry Wang wrote:
>> diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c
>> index c2df976ab2..dff81f6125 100644
>> --- a/xen/arch/arm/mmu/setup.c
>> +++ b/xen/arch/arm/mmu/setup.c
>> @@ -339,6 +339,33 @@ void free_init_memory(void)
>> printk("Freed %ldkB init memory.\n",
>> (long)(__init_end-__init_begin)>>10);
>> }
>> +/**
>> + * copy_from_paddr - copy data from a physical address
>> + * @dst: destination virtual address
>> + * @paddr: source physical address
>> + * @len: length to copy
>> + */
>> +void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len)
>> +{
>> + void *src = (void *)FIXMAP_ADDR(FIXMAP_MISC);
>> +
>> + while (len) {
>> + unsigned long l, s;
>> +
>> + s = paddr & (PAGE_SIZE-1);
>
> NIT: I would take the opportunity to add a missing space before/after '-'.
Sounds good, I’ve done that in my local v8 and also mentioned this change
in commit message as:
```
Take the opportunity to add a missing space before and after '-' in
"s = paddr & (PAGE_SIZE-1);" of copy_from_paddr().
```
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
