[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 06/10] x86/mem-sharing: copy GADDR based shared guest areas
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Oct 2023 11:55:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qt5jiyNVhpPgQuwG0sCmBK2m/Mdk3BY81XatDTvUZg4=; b=AtblVHVjS1YfcFK6pVuzBu91XCXeSrKVNFnFUsmG49YC7UdOJrtcC+jx6vS109RpGIY/bqaxL3e7Dnif0E6V1FbVwWOOdWRTgnUpSe09bfmzWUDL7cDR6RSSztd6zAI2Tw3n2HQCrtmGeKVb/7pCGSUDCFgYFqSmyNIZIlTMsMCeJBPSyfw2DYuZXTy/bZTdndfprGDoEZ3N2RPl2RzXa+57zsjhtkKntOEONuPzULMif+4SNGU+r0u7oMmX2Xk28EjJbha2oybpuOMz7bWk87CqO5GAAMa2RRMToVxvnjzEUSuJuhoCtW63m7uxXLvnZsH7OJljHv/8EDHOkWo97Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQGNabtSxeD+TabdJQSxe/2hBrlDUc6A4VfskdnMMrk/9z050jjD8YD9INEKfmeMlzn9HYTiVwWGiYc3Vdn3Xo4BpQZS3QVeERu73tXrpaNE5H310VdGeoaonauoGov05s6ky2wPoXlUhMLYGFnN/MhPwQ1fAbxuHZdzjJl4C5ydjdsddcP3D/M4Ex6kfuvWt8hZ9Zm1mcLX363KP9py87h0pvSyeAxjNS+R18N4RQIPRatLcHpJ6oMLAI9LSbEUHls1o+4gIzlslbdpENgnRKgHI7qjIcDZeU4i9jPlFDH2EohSBGqkXXuk9bM8BZKnnO0eeYFJFg+uhF9qTmbFwQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Oct 2023 09:55:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.10.2023 15:53, Roger Pau Monne wrote:
> @@ -1950,7 +1978,15 @@ int mem_sharing_fork_reset(struct domain *d, bool
> reset_state,
>
> state:
> if ( reset_state )
> + {
> rc = copy_settings(d, pd);
> + if ( rc == -ERESTART )
> + /*
> + * Translate to -EAGAIN, see TODO comment at top of function
> about
> + * hypercall continuations.
> + */
> + rc = -EAGAIN;
> + }
Are existing callers known to properly handle EAGAIN? I'm worried of the
verbosity that was no lost here.
Jan
|
