[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.18 1/5] xenalyze: Only accumulate data from one vmexit without a handler



On Mon, Oct 09, 2023 at 01:51:33PM +0100, George Dunlap wrote:
> If a vmentry/exit arc unexpectedly doesn't have a handler, we throw an
> error, and then log the information under HVM event 0; thus those
> particular traces within the vmexit reason will have stats gathered,
> and will show up with "(no handler)".  This is useful in the event
> that there are unusual paths through the hypervisor which don't have
> trace points.
> 
> However, if there are more than one of these, then although we detect and warn
> that this is happening, we subsequently continue to stuff data about all exits
> into that one exit, even though we only show it in one place.
> 
> Instead, refator things to only allow a single exit reason to be
> accumulated into any given event.
> 
> Also put a comment explaining what's going on, and how to fix it.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.