[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 10/10] arm/smmu: address violation of MISRA C:2012 Rule 8.2
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 16 Oct 2023 13:45:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zDKTH/aQs4frHvTevE4VxDkD5FPpkunc9JITpyjFltY=; b=JmWj49OKpzAjrphvI7Wm3CKT7lydE13OZj3qbkCbI6Q0/iHwFJr0dM4SxnBtfAy2Sa7uRRz83BeL4oqEx/Lmt8vZOM+0iV/+erOmc6XcQ9M+/c9lWv+tc1w27Iyt4aiPDUJGizKFr8kJpAD0nt6lS+nPc0mfkt8Tyrj1SphkSTI48BDy2Z0NclCnJwS3W9MAQdtkZrH5YnF4YTtRypKRTldoZGf8a6XEvcKaHDdVpLeaXFLdkCgG288Ns4qBf0tLKUliK5Mk7JGEarpdixO1edEcxYra5HGcgwPUnEwSccpGZIK8m2EApdotj1ghI22Oxd/EBaWoHwD8pncKl5FKMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNG6+FBdAMHrl7skWa6EsiHqnX3qBT6IponkKyxeEwd6szW0LsQmwFYmqQopCbHVp9SMv37eZZwd8STs+Wb7rKx4ANjh09OQf4qwEgets9D16NnqgyWh65TMH00aaejEnzJNfFKXnNF2LRj27I05ZC3kA4DuQzLc442lPLjB/lG7E/CAoem9iVbL3+Wn/cIFjvewDNpiMGEBuTQqqDWOiAcZ4PXSNBR08DZo7qTOwJ4Q7nQS4FpUa5Z6gfsFVKmxzsvrOPLzbw1mzVCOxVnGUmj/dpP/w4hj7L8VaLEZka/fW8GyVTqZ09+kvkZCNDOrfYVWWgd+7/I5SWG/m4K7Hg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 16 Oct 2023 13:46:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ/el7rXFHK+9WvkOYQpiDC7n8ALBMJIIAgABJsYCAAAH9AIAAAgSA
- Thread-topic: [XEN PATCH 10/10] arm/smmu: address violation of MISRA C:2012 Rule 8.2
Hi Julien,
> On 16 Oct 2023, at 15:38, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 16/10/2023 14:31, Bertrand Marquis wrote:
>> Hi Julien,
>
> Hi Bertrand,
>
>>> On 16 Oct 2023, at 11:07, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> Hi,
>>>
>>> On 13/10/2023 16:24, Federico Serafini wrote:
>>>> Add missing parameter names, no functional change.
>>>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>>>> ---
>>>> xen/drivers/passthrough/arm/smmu.c | 6 +++---
>>>
>>> This file is using the Linux coding style because it is imported from
>>> Linux. I was under the impression we would exclude such file for now.
>>>
>>> Looking at exclude-list.json, it doesn't seem to be present. I think this
>>> patch should be replaced with adding a line in execlude-list.json.
>> I think that during one of the discussions we said that this file already
>> deviated quite a lot from the status in Linux and we wanted to turn it to
>> Xen coding style in the future hence it is not listed in the exclude file.
> AFAIK the SMMUv{1, 2} code didn't deviate very much from Linux. I can't tell
> about the SMMUv3.
True that i had the v3 code in mind, we might not want to do that for v1/2 you
are right.
>
>> At the end having a working smmu might be critical in a safety context so it
>> will make sense to also check this part of xen.
> I don't buy this argument right now. We have files in exclude-lists.json that
> I would consider critical for Xen to run (e.g. common/bitmap.c,
> common/libfdt). So if you want to use this argument then we need to move
> critical components of Xen out of the exclusion list.
I am sure we will at some point for runtime code but we cannot do everything on
the first shot.
I was not meaning to do that now but that it is something to consider.
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
