[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v2 6/7] xen/console: make function static inline
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Oct 2023 16:52:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0PEBTswjW8DSv6/BhWUXIMgtJF1yVHvu7t12DDK24AM=; b=DAKqVlNxwf/bkLBo6IXnSaVKUrHNtbJ1iqf2UHbEg3MZVLLixXOpojUMDrzv6pFTqg7Qdvk+fjXkG2qBoPy+JPFX0KUSpH6qIQTnotHslxgZ7YTqWKjL9YJABp5LiOaWZmst5zymyuLnVIgCCnPXnqaPlZ+05hFMOKWiv5TayZmfGT8i4bG5Zv+wX/nXiWYvjLZhETATytesNbsnSwp9o05+ec7m6MsNZh8sAFKrUf9vDF8OXq5BQCJQKPDECR/PtD8BwEYj/sWIPCYB+a/1jX9P43eCNN7UllH2p5eEPpp6Csdy048MMPCZRWfPh9DzbmIWtFGVOS2WIqHHFdO20w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMICnmuZNA5O4ir3ZPrn6G14rjz/v3/Xi796ko7to4ZHdB+62LrqaxA9YDu/JJXKKlH9qvf2yT90MTfTGbCmt3UQP5rPRBsXuwoRv2ZyPXv9aMsuXQQC5CxPMmtioASf41/zSRVnEHgegqxxwaKp/7DPPrchiuap3KApZZ26GbrBZFIxYUK5Gd0O6zJFX5cWnAJqTQdNpfpYX7nPAMCguMEmPZEE5ewha33f/wK6OcdywQaVg2H5QVN1geZ49vxWfoz1GpjT7UjPaSMSEVQh/343G78xZzHWC+KG1O4WTXiMdbYuwQwS/wfpMOChc7FxQQs38Y2HMsJ7pizvl80uag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Oct 2023 14:52:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.10.2023 08:54, Nicola Vetrini wrote:
> --- a/xen/include/xen/consoled.h
> +++ b/xen/include/xen/consoled.h
> @@ -12,7 +12,7 @@ size_t consoled_guest_tx(char c);
>
> #else
>
> -size_t consoled_guest_tx(char c) { return 0; }
> +static inline size_t consoled_guest_tx(char c) { return 0; }
Why inline? We do so in headers, but we generally avoid "inline" in
.c files.
Jan
|