[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] x86/paging: address a violation of MISRA C:2012 Rule 8.3


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Tue, 17 Oct 2023 01:00:01 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ZNQ+C/iNvo0PqydzP2mEbiPdg73nPbPcmlonhX1kKE=; b=d9G70tGBgc4JcIV27vA7FmYqSGBNQYT1Ib+dmf6k5JztB7a67BYgF9q4ntC0zsP9G4WtXmF61y3mk2eNR6bZNwJrmjlT5btx/lPp+QNNBefDNdx+fhiYzY0KQo2xnKWZDT0KlpC4yNGQw//88y2qU8Nzf4ZdntaTNHbgcWEV9iZoJyCsCo2eCVuovW3yM/vS2iwsXr6vN5l4unE76VVP/ZX8u43bRQWZrlHc8ySIJaZMULxIlbmkueX94AvKwI0W+I7ovg+Bt2rNDfEWPkFNSU3GV+XBDEFPl3XXe4IJ1DFDwT8Au0/rLxpLrRuA9dyjK6LnkWZWjw80y/VsyCgwlQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvKeGiHuacbzEvZZj/pN2H/iiSFdiqRAnT+KgC6lkYW2uLvc0MBfqZgk8DS5s3df8ud0upz8aZnx03KJ0vW9R8v76ungiIExufpxjfejerqAXlzAWAVRaHU+rjmVYi9R+iPfjj2EwXCiGyVUmYO2uohH09wmsCThbSFGmsqnv5HiXs46yjave2TOFFUSkSYt7vxRXaZlegv0v909B+NHSiyjjG4ydLFeC5RL12capwbmtHWy9VypdOtlmOFdDRWKj9I86lYD+3w5uva2b9TOv8wRUh+Uc/ncvIDsi68wkm4Ur0A32/X27llAJRffC+VIQxrV2Ajwva/bjWpW2//fjQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Oct 2023 01:00:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZ9Ta/NlvugOvKeE2dpjYrdI/xh7A3GhEAgAAZ7QCAFWfTgIAApDaA
  • Thread-topic: [XEN PATCH] x86/paging: address a violation of MISRA C:2012 Rule 8.3

Hi Jan,

> On Oct 16, 2023, at 23:12, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 03.10.2023 02:19, Henry Wang wrote:
>>> On Oct 3, 2023, at 06:46, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>> 
>>> On Mon, 2 Oct 2023, Federico Serafini wrote:
>>>> Make function declaration and definition consistent.
>>>> No functional change.
>>>> 
>>>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>>> 
>>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> 
>> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
> 
> We're past RC3, so I'd like to confirm whether this still holds.

Thanks for reaching out. Although we reached an agreement that we need a case
by case analysis for if merging MISRA patches or not to 4.18, and technically 
MISRA
patches should be committed by RC2, to be honest for such a simple patch I am 
not
going to block it because I really don’t think it will cause a behavioral 
change, so
yes my release-ack tag still holds. Feel free to commit it.

Kind regards,
Henry 


> 
> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.