[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.18 v3] x86/pvh: fix identity mapping of low 1MB
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 18 Oct 2023 05:09:53 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAG1pFuqfUzD5Gh+gfcM1UJyliO1/KRfuE+PxZAWc88=; b=m+/hin3E8uEVXXA4ZXJ9iYbQ0lCKVAifvSQ2GrfHZ2u8rfCNAWmqVDOqNhcvPpSzGSFCQ5zw5BrBnMX5QI6WdtxhrZAy69tUmC7RnNiSUlVV+YLdTP6HY3nOXdtSshy2srnl8d4doZ0an24h9ZQBbSTes8GxUqLuCidx44s8Hu1izSYVV7JLZn1iL2vGPMWzHCxim0Ziybky5ftlc38E39MrE0hrZRv7yc/jfWeVAZJG81mSZo2MtTVPCoQvmgdC1nzu2XjPcx6lrkcBNvfdx603UHMaNQ8giA6sgJ0XdaIYXnvSOM8z0K0ka7sTbGaPHKxYWSDXwlyyi5fCxYkALQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTDDSPBOzpZtjoM4CjzFlaJC23pbwR+glClYSgs9zpc/k3AvAJ51j3ZdXGuVkyJMMAjc3kxWjTa9qz6TuIftfakhkgmOlZX4m5TC00K3aEEFYROPL+yUtcI2rk14LBExMyd1q0eiYD9CszPZNbnZzd4S7UzDSunOzMoOxBY8Mc2GvpbZi40htp+LjF/XxXXmqD2K0xw0ZVkxbvOFejZhMsIV16jdT/tuZyKDFc1cH+TfMZ39eOm6QFfgSWNliOtECSW9x0u66uXHLWoQ0kxIJsGBuX5EUcZ7U2IaliYfSSQK/eZEYIodj3oqDrzqao6MAo3ETUaPARXOiOEnUElDUA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Wed, 18 Oct 2023 05:10:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaANQS/LyQqw9DZ0a+r0ceZcWCMLBPAPAA
- Thread-topic: [PATCH for-4.18 v3] x86/pvh: fix identity mapping of low 1MB
Hi Roger,
> On Oct 17, 2023, at 16:29, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>
> The mapping of memory regions below the 1MB mark was all done by the PVH dom0
> builder code, causing the region to be avoided by the arch specific IOMMU
> hardware domain initialization code. That lead to the IOMMU being enabled
> without reserved regions in the low 1MB identity mapped in the p2m for PVH
> hardware domains. Firmware which happens to be missing RMRR/IVMD ranges
> describing E820 reserved regions in the low 1MB would transiently trigger
> IOMMU
> faults until the p2m is populated by the PVH dom0 builder:
>
> AMD-Vi: IO_PAGE_FAULT: 0000:00:13.1 d0 addr 00000000000eb380 flags 0x20 RW
> AMD-Vi: IO_PAGE_FAULT: 0000:00:13.1 d0 addr 00000000000eb340 flags 0
> AMD-Vi: IO_PAGE_FAULT: 0000:00:13.2 d0 addr 00000000000ea1c0 flags 0
> AMD-Vi: IO_PAGE_FAULT: 0000:00:14.5 d0 addr 00000000000eb480 flags 0x20 RW
> AMD-Vi: IO_PAGE_FAULT: 0000:00:12.0 d0 addr 00000000000eb080 flags 0x20 RW
> AMD-Vi: IO_PAGE_FAULT: 0000:00:14.5 d0 addr 00000000000eb400 flags 0
> AMD-Vi: IO_PAGE_FAULT: 0000:00:12.0 d0 addr 00000000000eb040 flags 0
>
> Those errors have been observed on the osstest pinot{0,1} boxes (AMD Fam15h
> Opteron(tm) Processor 3350 HE).
>
> Rely on the IOMMU arch init code to create any identity mappings for reserved
> regions in the low 1MB range (like it already does for reserved regions
> elsewhere), and leave the mapping of any holes to be performed by the dom0
> builder code.
>
> Fixes: 6b4f6a31ace1 ('x86/PVH: de-duplicate mappings for first Mb of Dom0
> memory')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
