[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] arm/cpufeature: address violations of MISRA C:2012 Rule 8.2
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 18 Oct 2023 16:57:08 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9SSYl09/YNSdJREsa4NJqyceIX6U7xNIcXTttQPm2ec=; b=LTy7AbnHfDSWmt/WuUY0SwfQS28SDBHFr7FJAKaek2k82JsFrewR9ZrQfJUuTwk6SvtnghcJDOqCMG/0zArjMtTW7TItkZP0lK/5rVQNSFSKs7Hs4t1yBBDGA9LrBl5l3HnAo+5jp+gfHkrPZ2pkO9EJmoGdJl0g1yZjwrdi7MOZzynAHdxVCb/8BRv13lDDv8xz6vV3qyL8wkYu17e4RoPoRAhMQWFcSe7iKqaDIhE4qwpHvaT7rrRGD6bFUO/1lQfxqIjvu/R+izfwY1HpX3MPoWa5cbz9A5PmJ8nZo2bJqml37xK/JLUAR728tJ5YOKSSYQEGhgwhKn7gG0CENQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBT3nAMPr83g929ZcUL1nLTNEFOLYgbI5xl1cxyPq3qiYSc5c8eLJ6nQ/vkx1GwyrwLLLxSeLlw/k3Ao7u/sAIaA4Tq+0nPxDPcRuPUZ7RHe/gTG+GDi1Qoed5N3VZTAisUuInj6iXc5Q7ZluM/rAqJyqJ2vmB5Xr57K8BwbGqswN7vRWM3LazjTtxL3IBlArIcIoHvHH803T4DQ7QjcUAs5K1C7eiiCoigjQC0WL8IWKzhp2QqBBMMTD3RwrHHq33bxytbXugwNBRs49kCNABMo8WyToyhFeXj/3bK5v34DlG2X3fpDQM3RjERX7MKjf8CiF5xI/QY2EJtiB5LD9Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Oct 2023 16:57:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaAcHJMtQzql3zbUq10ZfwUNid8rBPxLGA
- Thread-topic: [XEN PATCH v2] arm/cpufeature: address violations of MISRA C:2012 Rule 8.2
Hi Frederico,
> On 18 Oct 2023, at 14:50, Federico Serafini <federico.serafini@xxxxxxxxxxx>
> wrote:
>
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Changes in v2:
> - fixed names.
> ---
> xen/arch/arm/include/asm/cpufeature.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/include/asm/cpufeature.h
> b/xen/arch/arm/include/asm/cpufeature.h
> index 8011076b8c..c95582044a 100644
> --- a/xen/arch/arm/include/asm/cpufeature.h
> +++ b/xen/arch/arm/include/asm/cpufeature.h
> @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num)
> struct arm_cpu_capabilities {
> const char *desc;
> u16 capability;
> - bool (*matches)(const struct arm_cpu_capabilities *);
> - int (*enable)(void *); /* Called on every active CPUs */
> + bool (*matches)(const struct arm_cpu_capabilities *entry);
> + int (*enable)(void *data); /* Called on every active CPUs */
> union {
> struct { /* To be used for eratum handling only */
> u32 midr_model;
> @@ -448,10 +448,10 @@ struct cpuinfo_arm {
>
> extern struct cpuinfo_arm system_cpuinfo;
>
> -extern void identify_cpu(struct cpuinfo_arm *);
> +extern void identify_cpu(struct cpuinfo_arm *c);
>
> #ifdef CONFIG_ARM_64
> -extern void update_system_features(const struct cpuinfo_arm *);
> +extern void update_system_features(const struct cpuinfo_arm *new);
> #else
> static inline void update_system_features(const struct cpuinfo_arm *cpuinfo)
> {
> --
> 2.34.1
>
|
