[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 05/29] xen/asm-generic: introduce stub header event.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 11:18:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CKHoipP/APf5T057x2ogsLBsB+fPgqZ5QMhPdRoaEes=; b=JJBiukhWFZtNgkyfNi19V07AuZIMIPoAQjtoQ+kC5IX+tT1HFTOTXLlywxFe/EMMgvHI751DGylsXc/ZeHPDba2+gXWjPtm5JH7XDABRcLOWFdv9P+9Tbr3bcxpQCy/7AGSegGlK7O7bxKR7S0oUaRYpl+YM4/S1E6ePP5ZEd8wpr3OFQzrz8B8xZUvxbdE19oNa3ErrBjXg24ikHd3VtlKgyJaV4b+vPgCrGj5NtOgBpPmyVCwlGrgRZPUSIN7ESeHZDbUAVv3IMcb0e4max+TuGebRYJT+C257g7LWAf5gGDHPHc54WTWeUVnUa/ZmapXm8cXlLif2K8fOctrbTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfiUf38bDXcU0l7seHt+eT8zrTs0/m7qgZmMA1mzEIaE+RrS7ytVFpFUFVdlCXRqlvzbrcR1IeWYrVEUVRrpmYhE6hTSqfP6zGcSdzxDGvlMvm9IpaDfTgL+uoB1whzCy4Ujw7A1BCAaTjnqYJhhcxg/S2A7sglmsDLZWFipB6Qiih3lHIjlQYKwpadS2+mc17lKtlcmpPHiug9RpZRU0qU+s9USITKJAdG4Mz05jlSyA/56R2noHcBn49J2u2GpdaTqCGtXu1qkcm50/zhYoeRduAOA5HL4yvp8tbve7EuBSltvD8DdVMbkJ5e0y2wJ0auF0PZjgr1Lj8Ucx8XZDA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Oct 2023 09:18:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.09.2023 16:56, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/include/asm-generic/event.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_EVENT_H__
> +#define __ASM_GENERIC_EVENT_H__
> +
> +#include <xen/sched.h>
> +
> +static inline void vcpu_mark_events_pending(struct vcpu *v)
> +{
> +}
While this will satisfy callers from a build perspective, no port
will be functional with an implementation like this. Yet the
generic headers need to provide the required functionality, not
just build stubs.
Going further in the series, I won't repeat this kind of comment.
Unless others disagree, my view is that headers put here should
be of use beyond initial bring-up of a new port.
Jan
|
