Re: [PATCH v1 02/29] xen/asm-generic: introduce stub header paging.h

[Julien Grall <julien@xxxxxxx>]

Hi,

On 19/10/2023 10:05, Jan Beulich wrote:
> On 14.09.2023 16:56, Oleksii Kurochko wrote:
> > The patch introduces stub header needed for full Xen build.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> >   xen/include/asm-generic/paging.h | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >   create mode 100644 xen/include/asm-generic/paging.h
> >
> > diff --git a/xen/include/asm-generic/paging.h b/xen/include/asm-generic/paging.h
> > new file mode 100644
> > index 0000000000..2aab63b536
> > --- /dev/null
> > +++ b/xen/include/asm-generic/paging.h
> > @@ -0,0 +1,17 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +#ifndef __ASM_GENERIC_PAGING_H__
> > +#define __ASM_GENERIC_PAGING_H__
> > +
> > +#define paging_mode_translate(d)       (1)
> > +#define paging_mode_external(d)                (1)
This is more a question for Jan, in the past I recall you asked the 
macor to evaluate the argument. Shouldn't we do the same here?
Also, I think we want to take the opportunity to convert to true. 
Lastly, this seems to be using hard tab rather than soft tab. In Xen we 
use the latter (unless this is a file imported from Linux).
> > +
> > +#endif /* __ASM_GENERIC_PAGING_H__ */
> Looks okay, but wants accompanying by dropping (i.e. effectively moving)
> Arm's respective header.
FWIW, I would be ok if the change is separate. I can help to write it also.

> The description than also wants adjusting (it
> wasn't quite suitable anyway, as there's missing context).
Cheers,

--
Julien Grall