[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 18/29] xen/asm-generic: introduce stub header smp.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 12:58:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mkEoCjaAANDv902aIsa8FTPwP0/8ENWU6TwgUbE9TFw=; b=TkYJ7BCY0cKMszWG4gj9Wro/yVm/UsHUlNFHnAlmG6kOHewsk+f7gE46fre+ZIT/JLjPmaUhp/zLu3nC1oxIYjm3ASsQ1gs1anu5xZFtrOhha35q/Yo43TrTtu0MWJQeVdb0WxshxZPSsRS1HwP+mRNBdCUCTbi6Ke8dG3tJuTyiF1qz0vXuT3xmQZgnQ3wdcChm0BhuonXdxjMG1w3m4Y1PkUtuRoaih29MzSc4LbKczLB7GlVCdZGgEG9mv2u6k0nObuc88fSmJFYzqvTEnLm6iym2BNqcLL4+qnT6FKXIANdUpSQ6n3rooROikyLtbkiHxsGe5dg3lrEswzBsjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+Qyb7KishHYxMQbl8Yn3TgXPk9aSC0pXz9ugJlgLK7dCq8FiXMqqEQhnQT/9inEqBoF/gQOfGBAEzPN5cftbe6gnifWqbWfTBHaRe0zAFaYWBMOEzRgHbOy2kxesevlgCpsWN5JxFu/piaRCFgYu/PY7G7D2qLr7NmQrHBnmHEKozyT+Xxbn7kK5DASPC2O+2cjAZCdIXtR9HRDlZi3s7rTDDWEmNw/CCrNRqBz1/dMJwQqA8cGYa91fcIs/k3YVz6ZF530wH1DeUftdk7f66Svnczb5XCw9QDNbqG9RjZ5R5/jpRYXxuBTECz1SIa18VjCVtz0bo8TqtXBGfD3hQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Oct 2023 10:58:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.09.2023 16:56, Oleksii Kurochko wrote:
> The patch introduces header stub necessry for full Xen build.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Assuming you expect RISC-V to get away without its own smp.h, just
one remark:
> --- /dev/null
> +++ b/xen/include/asm-generic/smp.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_SMP_H
> +#define __ASM_GENERIC_SMP_H
> +
> +#ifndef __ASSEMBLY__
> +#include <xen/cpumask.h>
> +#include <xen/percpu.h>
> +#endif
This #endif need moving ...
> +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask);
> +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
... at least down here, if #includ-ing by assembly files is really
necessary to permit. Preferably the #ifndef would be dropped, though.
Jan
|
