[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 25/29] xen/asm-generic: introduce stub header irq.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 13:34:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k+sOnk7pfsJCIBixwM4iGZyICMVqavENGBaAPr8tuJk=; b=HiSdmaY8zg7f8Ryl/XuHzYw3YHNMUUfNeEBC3Zv1GzbUsP2Ii86FnvkKkGHjHXE1tTdmQcW43zQmVBZEq6UAnX25now2OFYKy9CeEfP3OQHvZDymkkVzs9pwWwxg8dxn2lPkCYUBWiDCOn0VYlpVX4Cglh+e4CH0DrulIClkYavIOL7XdXD6xdVabQMy51kDQHCy/FGaZwssOz8XlZQWOPKTCzx27RE09oGL5p2n8GUnONw2667Aeqb62Js+0f9Efn4qNWOTdeqkS6nVj4QWmU7iEJRXeoURLpJqD62/VKtuZA1lDsegIQKtixISrAhcEh4GboDH/YQ5dMcjgPRFGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6xzsN6vP5ofwz4Txk2Me3jfTGiOOFCymKkSAfa7YsCfk3xCwsCsbv9wQ33VQ3Xo3T8dzu/C8nlncCMO5caCNeMhH1YFNY5NZpJImGcaV2FsANudgsA+HL7TUlepi0ODFvb0e4ziL9j2urjC61Lhd+2oCR6U8P4asKo8umV4YPBvVnw4/nSr90v/3Cub9mdt6BHPwjHj/E8ipYtODqSPPsRbZreCpkKanzmv5Av/ZRfLd5uJ+ypmna+VU8msBdwkqcpIjAgRyEtx1gvsHTmPR3FbXJs0BD4iucv2HdveqOyKMbHGe2AOmrbYHm/NFPOaF7Ofr8B+lMZIbR+rwNMV+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Oct 2023 11:34:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.09.2023 16:56, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/include/asm-generic/irq.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_IRQ_H__
> +#define __ASM_GENERIC_IRQ_H__
> +
> +#include <xen/lib.h>
> +#include <xen/device_tree.h>
> +#include <public/device_tree_defs.h>
While Julien and I are still discussing this aspect, my view is that DT
things may not appear in generic headers. At least the #include-s here
aren't necessary anyway, afaict.
> +/* TODO */
> +#define nr_irqs 0U
> +#define nr_static_irqs 0
Earlier comments apply (at least) here.
Jan
|
