[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 2/3] x86/hvm: address violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 18:02:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+m6EROmYhCJOGP0SLj7cRx7h4LUMWM22ivHs6SHRDs=; b=BkHlsfSsDIV0Yh2vNi+ARkp6phmLMT2+n+YjkXNDf4cPLdey9cEniLdijGQPJfBPosFN/JjtVhODbGaBfwQsI+UY8z4LTd2xBJSNl8r+PHz5Chis2n3d0ZvzfjwWTpAiPL/ALsJzUtq+ca1B0GxTLK3rAFuQgszXTTsAPwTqMx0vc3/9CpdeRt9PKeEPEBLdzvO4DuMYyC0oT0Ifv0qrfl52EpMWnBc7FDS88xO23aiRAWFppCnEjmcAUO0UccVH9t1Ggq8QTzzrBxGEqOnYCkj1if9AvuVggk6+xaun4tAWjiYscFquzrH2ds2seYPiwIs8BqJJ704Qd9itR0MQcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnjUPWkitZaFvW2dDz0c/PEJVXmD0Gm2dnh6b60FsYHKMxZgBIq3UgmP5yQe8HMhkUE5q3b0JvsHilFKbt+MdsfLkUslvkra4oPD5Bp1fQB7ziDi9vEx8HLvyxngCY4Qeb/xu62Jb/IS3wFuu0okASsfihNAzbI++VqVHcnJvO5UXtCtNG3M7M+0qV79naSkBM1BC9F8QyoFs+dLtA0YftUzZtlo1x2XUChr8Ui+q/MMcpMzK5f/9DSQ5gmztiwMZYo/0Iy5xA5m7n3hRWh4HNIPe2fzMN0yn2iVrmyyhypNnneNspGMLWHWwKWqdEyEWlEaZSMkxTkfasVbeIX/Ag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Oct 2023 16:02:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2023 15:11, Simone Ballarin wrote:
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type.
>
> For the sake of uniformity, the following change is made:
> - add 'U' suffixes to 'mask16' in 'stdvga.c'
>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit ...
> --- a/xen/arch/x86/include/asm/msr-index.h
> +++ b/xen/arch/x86/include/asm/msr-index.h
> @@ -22,7 +22,7 @@
> #define APIC_BASE_BSP (_AC(1, ULL) << 8)
> #define APIC_BASE_EXTD (_AC(1, ULL) << 10)
> #define APIC_BASE_ENABLE (_AC(1, ULL) << 11)
> -#define APIC_BASE_ADDR_MASK 0x000ffffffffff000ULL
> +#define APIC_BASE_ADDR_MASK _AC(0x000ffffffffff000, ULL)
... this looks like an unrelated (but benign) change.
Jan
|
