Re: [PATCH 1/3] CHANGELOG.md: Mention the MISRA-C improvement in 4.18 dev cycle

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 20/10/2023 03:31, Henry Wang wrote:
> Hi Stefano,
>
> > On Oct 20, 2023, at 00:13, Stefano Stabellini <sstabellini@xxxxxxxxxx> 
> > wrote:
> > On Thu, 19 Oct 2023, Henry Wang wrote:
> > > Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> > > ---
> > > CHANGELOG.md | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/CHANGELOG.md b/CHANGELOG.md
> > > index 165c5caf9b..47e98f036f 100644
> > > --- a/CHANGELOG.md
> > > +++ b/CHANGELOG.md
> > > @@ -33,6 +33,7 @@ The format is based on [Keep a 
> > > Changelog](https://keepachangelog.com/en/1.0.0/)
> > >    nodes using a device tree overlay binary (.dtbo).
> > >  - Introduce two new hypercalls to map the vCPU runstate and time 
> > > areas by
> > >    physical rather than linear/virtual addresses.
> > > + - The project has now officially adopted 72 rules of MISRA-C.
> > I counted them again, they are 71 today. We have accepted 3 more
> > recently but for the CHANGELOG.md I would stick with what is on
> > docs/misra/rules.rst
> Thanks for the pointer of the doc, I checked the doc and noticed that
> we actually support 65 rules and 6 directives (65+6=71 so you are 
> correct),
> but to avoid the confusion, would you mind me writing in this way:
> "The project has officially adopted 6 directives and 65 rules of 
> MISRA-C”?
> Kind regards,
> Henry
Just dropping this small suggestion: the general term used by MISRA to 
indicate either
a Rule or a Directive is Guideline, so it's also correct to say that 71 
Guidelines have been
adopted.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)