[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 7/7] x86/hpet: address violations of MISRA C:2012 Rule 8.2


  • To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 23 Oct 2023 16:18:17 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nw7JHfK/qcz8ichvv7Mp9PJIULjSkz9KyP/6NX6T0og=; b=k3oEVxMkrCjDWm1vr0gW9SAf6KFaN1mA9VSLC8L7O2iVY9jxv7w+bWogYv8/baIbQdbYaviIOLHIyTz0LEQYKVUCr1wEc4N6+lmJ2DKmF0vtLNgoWXGJ+u2I68/4yGjFJITBd0WcX+Ab53mNsJsxyyRNLRIkrXNx+rADnQcDOABk+jxkZ0DfkAUYh28b/eTwvQS2Z0mPp55wD4yAsylAtC4/bONGElIVz6PkVwHH2uU56xaFzxZOcbX0L4UC8zUb6mWfnNJkSLkMssiphy3rSM8NOvDuw4Plha7dTUHL7qTADoiQmKyzRWqWYo0bQRi5RgP+L7B3KkV6x5t6oyt7MA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQSSPYQvqjW9qSEL+0SVSIbROWXbum38NQ3IQ6hi1CufVooPcr/mI/c9lc6NeJ9Iopk7W0Tx0qGweRPtloVxVO5NsweWhpo0MNaDXlEQcRsHmYtMSk0CZB/nY0zJN27tILlLnDH2BzuuyfqnA2mnA9GHHhrwwX4AyIzcyGjaerD9hg65360j1AqZGLWlUCK9tW02rhgF1ip77poCav4RihxdXJFKJXAKlU3Wr3cVnMYsE4D1NiZb3DDnSgYbXUPMK8OCYqBktVevVptNOPKhtE1WrJmpJIRRuDgMdH9TVj5xhc57uh0EctmxhiuRoMu8jWmjVYILv0sW2qOigGATKw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 23 Oct 2023 14:18:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.10.2023 16:26, Federico Serafini wrote:
> --- a/xen/arch/x86/include/asm/hpet.h
> +++ b/xen/arch/x86/include/asm/hpet.h
> @@ -60,7 +60,7 @@ extern int8_t opt_hpet_legacy_replacement;
>   * Return value is zero if HPET is unavailable.
>   */
>  u64 hpet_setup(void);
> -void hpet_resume(u32 *);
> +void hpet_resume(u32 *boot_cfg);

Ideally also switching to uint32_t while touching this:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.