[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19] xen/arm64: domctl: Avoid unreachable code in subarch_do_domctl()
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 24 Oct 2023 04:13:26 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lMghLnZlIGl/tEdH/YcB6wwci4MU65sMfNA8M1HBAzA=; b=COO3YafJsiCGvyymimz16XWAmWYqEI++ONbrq+SU4dFZzjzuMW/U/LNQ0qbWOJ0g6t5ST7GYblXCFLHGZ7oeJZwr7FF4xZBMX7AIlTDq7loCmD9y2Zrc3GY2kWV3uQtl74ZEWQbDYSMWAETwIUWvZsRD9gfmvIHjOzEukiJHpzaMN0NMX/6ruCKIeJELfzk7xJpfcZACEGRmH3dZmKiaug8K2CFogN5EqO9QxZ2h9B2WjzFZpNk81M1ifBNVjFNa3jGaIO3pSPy6FkvIpTNjLQpUbAb7UQxHorUJzIzk9PhguFeLUmZeBj22NkZ+HPh2ol5wySyZDBEs1VnkOUxvGg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lMghLnZlIGl/tEdH/YcB6wwci4MU65sMfNA8M1HBAzA=; b=YYcb7LoxlahkOfS62bqSrfQfPg5NivvFZo772HibfU7c4XGiBHAfZsACPb9kdUkdJu/lC2X57HpC+yBRHZMuVIHiN40EpjB39YvLjrg0HHMeVf5VbJ+zzhGAS5sMTWvGcYzrIrTYRngZnR6/rGIfQGV95S37hzX8rEKeUXvbzu+00Mat0PAXfnF3rJj6lqj8fz9AfMSeXgA/Z7ZyU6Wd+6n5O09cce+uzUGayWB+nJBEFpGoCwTKSxd0Ba2nFDIX+68MnCq1ieA7eBvgEP1vodpqfESWcJLmxUK8Tq3ZCNfChmdrVBZBInZBs7VVac0m+8n062ruy7GtwvFxAE8c0g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lH1iwLhurV9f4iyzaoU1I4sajuLbXoofm5TzcctH+d+d68R1dxWR9W6VX/6jw8p7JwDRrSGDjtbTlqb3gW2g8ZFv7RExqBDjbcN/F0ZAdZji4sYMPsYKdcU1RUqsIUW8m586ImzBBhILyGLnUlL3NnBci0PLJJHFRQOZ7GdE9FqBwY1vVR2129kkfAHiIDwRpfQSY10S7cu3BEuIHCDjgQ3zuQzK+isYh4F4yYPGXTqcWgtKEdCYfz5dFKP62/5WhoXMpVOYc3rsZETKk9FJqb6nNOSMxZ7vCC2JdgJBJob6T/sm/bVc/2XOMRhHJwN35zytLFRI7N4NSwXbtUhNYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2KOWt8Tb+t5bouEwl4hi9v/hJB6RM5/6zF7doosfWq1naXMNb5+GCyoaFp4ZIXWpuOpwotnARPBAyN/jeT5XSrV/Ds4Xkn2muUqC0WcSPtipdPmPkQE0As+inMh5yvOYPdIO+ocfk3fZ10szMRyimeTiV12KOE51hBlPHgE8Eb2YbjqW0UqfKADkO8joIrVANdThe/q2acj+9kl6sEMQAKkE/+kR+OxnUI1DN1JfXPRUW9Z6FzwPrqI3WtHehMZD12MuMe8gYtPTaFpwg5ER0VcwrlGhNZu+oMvmzYGCOkaAj8588O49uH/rPW9wlvxoPjsBK2w9DJpTW8AoQA9PQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 24 Oct 2023 04:14:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaBdm+QtPk0OwtbkKhl3mh8vCsNrBYVR6A
- Thread-topic: [PATCH for-4.19] xen/arm64: domctl: Avoid unreachable code in subarch_do_domctl()
Hi Julien,
(+Stefano and Bertrand)
> On Oct 24, 2023, at 01:52, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The 'break' the XEN_DOMCTL_set_address_size is unreachable and tools
> like Eclair will report as a violation of Misra Rule 2.1.
>
> Furthermore, the nested switch is not very easy to read. So move
> out the nested switch in a separate function to improve the
> readability and hopefully address the MISRA violation.
>
> Reported-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
> ---
> Only compiled tested. Waiting for the CI to confirm there is no
> regression.
I also tested this patch on top of today’s staging in Arm’s internal CI, and
this
patch looks good.
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
