[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v4 3/8] x86: add deviation comments for asm-only functions
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Oct 2023 09:50:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/A/s2bLBiDx/C0FK5HfiXvTKl/xB4vyrkZUs1dTOIU=; b=jxq3wAsYiwudRZ8LG+h8mnr8M4Lh7snu9WK2rmU1zD5qT+A9TEv3Ndmo9uQdY1X46rsIFuhCQOuw/hCrDSeWaH7Cr+pwmlOHLWjisQxfJaSvAtZMOI/rn0jTCzq6Vv+3L4Yny0tKl6oTMz0/sW9j8AJDlxrGFVNZXoqS57J0eBs2l/MXbKRdRT+t+SNZkVMdObh8uzX1bl460ivJTwxJtY10+XM0Hdbv1gQRZn71gtH+S+POBOu3PWhzEhlC/EZjmQjHMIiZaWXUi+jWVfcyAQ8JuTO07IDxPrA/RNgvMDb1NsC1+kSXXUAUZ3UFJ67F03Qm8an56gpmZEbxoxmSmw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MoQAoniCeNWB6lfyqdD0eUQCtd+sEWj/SFACaV5jK70JqdmIeMSV+IItjxOP91OQ4sVP+pNzjATCI5zHl4djIOeEBUwFvVxDbz+pzwa1HtMDc8RWEspbTQlkzn8gXV/CM1CC+t0cnivupPE/V6WVl6utc51xB743Io/PQNFv5kXtd7EC08z9ClYMzdDrjWlEr/4LvN3qqLKWjFs+1INrc47p0yHQ8aVTDXRSLrZ13NCt9WcXSerVnV22mOteJXb0Dp7N7ViqkW2VPAASmEdtEF4Kkt/l64SYRT+pH87NBDUanJv4Rqbh//CLOUu9OFtc3I6lNbZfyYbISyyi95a7CQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2023 07:51:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 11:56, Nicola Vetrini wrote:
> As stated in rules.rst, functions used only in asm code
> are allowed to have no prior declaration visible when being
> defined, hence these functions are deviated.
> This also fixes violations of MISRA C:2012 Rule 8.4.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> Changes in v3:
> - added SAF deviations for vmx counterparts to svm functions.
Same comment regarding the R-b here as for patch 2.
> --- a/xen/arch/x86/hvm/svm/intr.c
> +++ b/xen/arch/x86/hvm/svm/intr.c
> @@ -123,6 +123,7 @@ static void svm_enable_intr_window(struct vcpu *v, struct
> hvm_intack intack)
> vmcb, general1_intercepts | GENERAL1_INTERCEPT_VINTR);
> }
>
> +/* SAF-1-safe */
> void svm_intr_assist(void)
> {
> struct vcpu *v = current;
Linux has the concept of "asmlinkage" for functions interfacing C and
assembly. Was it considered to use that - even if expanding to nothing
for all present architectures - as a way to annotate affected definitions
in place of the SAF-*-safe comments?
Jan
|
