[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v4 2/8] x86: add deviations for variables only used in asm code
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Oct 2023 16:27:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ASSYmQwZBIx1bB8RhQuEVfQxm2TNmLZyuCT0rbjrlSg=; b=EFbNwOILCNkHjK0229MuWdsJPbsAd5H/2fhYpD0H9VaWJJuUo12LrYMt6kVexhoIzFFORsBhs7y0akcMYAeE5leJodVSKPXQBufwrk5FVTAaYCGh2JB7SqBVqGUMcDCK8+uqy/pKmEDuoXXc2G9J8PiWuppuETjM0f47VDg8tVpgarkbR56hLVhyYhyBS0TTKx4L+kJjypZKWswDD8JPLZnonHGBMfsXocSt77xLfrjD6BllXcHOjGqzgwX/k+Ms5OYy1+CggGxZPZ23/L+6sW91pW4BcxWrt9hnTLfPGiuR2wZS5cIj6MWoe1NLOf5XW4iZswzNVNWNWU7srmCXXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aLX1XJWMvI0DI2CrGV11l9vJB37P55ZZbGBlTt9ltLYKSS+3oNdrMPW8Sl/EbQhVsfOscnsQC7NWm/7Zt/LlpQL1NWqYReFGDyE/CBWWFzODdGt2DEOVYRBpXrG3cg9M+3VbdybvPfVNDklaTRGA4PfpW1BJtcfXnGrJbFzQ79YoJds+F0Scc1dMWI6vAVHeoUiC9zBtCcWTIEk2a8ecK5+bnVSS1cGa8X8Ww6lbMQG9KuRV9bbfJE+9pfUMuO4yzPo6vUtoqqd4vkvrgrMmHLPbO6DXJHhb/Bi2D3FtIknQ71YQilGCe/QkUvwo1NXa1tFDe9WocDa0eNHjgxPEMQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2023 14:27:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.10.2023 15:40, Nicola Vetrini wrote:
> On 24/10/2023 10:12, Jan Beulich wrote:
>> On 24.10.2023 09:58, Nicola Vetrini wrote:
>>> On 24/10/2023 09:32, Jan Beulich wrote:
>>>> On 23.10.2023 11:56, Nicola Vetrini wrote:
>>>>> --- a/xen/arch/x86/include/asm/asm_defns.h
>>>>> +++ b/xen/arch/x86/include/asm/asm_defns.h
>>>>> @@ -31,6 +31,7 @@ asm ( "\t.equ CONFIG_INDIRECT_THUNK, "
>>>>> * gets set up by the containing function.
>>>>> */
>>>>> #ifdef CONFIG_FRAME_POINTER
>>>>> +/* SAF-1-safe */
>>>>> register unsigned long current_stack_pointer asm("rsp");
>>>>> # define ASM_CALL_CONSTRAINT , "+r" (current_stack_pointer)
>>>>> #else
>>>>
>>>> SAF-1-safe is about symbols "used only by asm modules". This doesn't
>>>> apply
>>>> to the declaration here.
>>>>
>>>
>>> The wording could change to "asm code" if that is deemed clearer.
>>
>> Question is what would be meant by "asm code"; "asm modules" is quite
>> clear.
>>
>
> Well, I don't know. It's up to the community to decide that. It can be
> an ad-hoc
> justification, but I don't see much value in doing so. What do you
> propose to get this patch
> approved (at least on your account)?.
Drop this change and have Eclair recognize that what we're talking
about here is just a declaration, not a definition.
Jan
|
