[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/ocaml/Makefile.rules: use correct C flags when compiling OCaml C stubs


  • To: Edwin Török <edvin.torok@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 25 Oct 2023 16:04:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7GcS7NTqBQQL8SPqbl4FS5pMWN2TOUh2BHFgtwkottU=; b=dHBZDJpoMTW3Io0/bELH1GxpSsQFw2Q/HYKKNmYsxc+STucrNEDI6FCo/45RAJOpL7liES9K9wikpSbbGAH594T0pmfDsQnVL+FUWm43HCyUEeJMYJ4GOK6wI28UcJ8fi8+gyKd77trK20okQBq7x07fygR7xbgxi2xPVTqFbKNQmGmrSRJLz9g9sDRep7nqmanTHpJK/Z6vMVj9gRauw1MJYn3PqsVOtsqq3Sf0EWyRfMJ6Up6ZnxF+X4o8My8aI7ch42T7vluXeWx1B0XQsZkDJVv9k2Xv/4L/MT/OyMRUgK4dlQfGSkvbeUinXv2OpUolQcnoTA4vhn3Q85PL+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKVpOqlI5zO6cyGpJROaOVUWJE46W+7zy++0bHFm7rcdvcWSor3dJSmRET/0mlQLqhRdi30tcODHNl3FjDylJKyZaCAeIfy91ucnyQmeVCvMwmsvqZ6xNLg8hxPGGwbgsakm8+a7geVaXzIUxmMxHZ7NjRZs7IxBeUtnWwxkakQBFntVezQgjLLX189lwOyl3RP0YkBwj5w1PTpsKktWkc+aiDviXTLDYYmWl2K+60KH51VdDJqv89JlPg7pCoaSsrO6QVZMg3Z9hJA1g0BqIAHDYykNpJ5VwB2oq2k3u1uSAMQCyLc0P+mwWDV3oi2zphmhMUghjWBCpVOIRxexpw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Edwin Török <edwin.torok@xxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 25 Oct 2023 14:04:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.10.2023 15:52, Edwin Török wrote:
> --- a/tools/ocaml/Makefile.rules
> +++ b/tools/ocaml/Makefile.rules
> @@ -37,7 +37,7 @@ ALL_OCAML_OBJS ?= $(OBJS)
>       $(call quiet-command, $(OCAMLYACC) -q $<,MLYACC,$@)
>  
>  %.o: %.c
> -     $(call quiet-command, $(CC) $(CFLAGS) -c -o $@ $<,CC,$@)
> +     $(call quiet-command, $(OCAMLOPT) -verbose $(addprefix -ccopt 
> ,$(CFLAGS)) -c -o $@ $<,CC,$@)

Wouldn't -verbose better be passed only if the build isn't a quiet one?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.