[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v3 1/8] xen/include: add macro LOWEST_BIT
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 25 Oct 2023 17:33:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7t/Thl0XEeLJ/joxaDu2iaUZWKqeolnRMT2FhZ6bDMU=; b=lZ8Lm+wo3mJozLjhAOyPicezMgzWu0KTYMITODvrRW8OO9l9oBGDekZX2Cop96AVkQ2j86V0LV5anu/ir8bb5E5Hbixs4Cv8eaEFqcPlKAIufXT0yWvWxaoKfhCmI8ojdD3T3lRrc5bjA6cNJOQscJcpMKpel1DhpuSKbXTcLK7zPzV7JdFK88I71DQDiUh6NmCcTgu7vUsKLXn8ZVYso9ks8Q+N+rLMsgZR73+t4heuGkB+1cVpPD/yBugql/rTWFBKLPnVBBoPnRg/xWwuuw/tgPzDsGOEw6d4tNvoyPwQNdY49VGSVjG0venW99HrYfA8BQI/3U5BuC0XiPPTsg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MfWJzwOZZyvsH/1qLmYMx5CIlDM/rOcXfuWiN1xAUkJZIxOTZ+Hro1AsukCnzghFbO+tSpgqnj+NhGwJ0FZrzkvlv6w/liA8ytx9nNNcLzmmVKuL+sNBDep4le0En58IxTdvESHTehcD2FkmP+GyktkhYZR8UhOAeXxOH922CbAMZePBFfpssZfgI4i6fhDLrj5pzIX7t8jY5e9UAh9+tysK4sJ7tyb2sFxblQEY/4lfWy2yAkpImWUtO+hwqISaDgmYZyabb6SMUalCKwt5N32oGXAPoypKyYXaQYkw948vMMDvWV48lG3h/jehOERXN6yvqgHz6D4betDayziuOQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 25 Oct 2023 15:34:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.10.2023 16:50, Nicola Vetrini wrote:
> Ok, I'll send a revised version using MASK_LOWEST_BIT, taking into
> account also the
> other comments about the explanation on the macro definition
> (which some IDEs even show when hovering on its usage, which could
> partially address
> the latter concern).
You're of course free to do so, but since - as indicated before -
MASK_LOWEST_BIT() imo isn't a better name than LOWEST_BIT(), I'll
continue to object.
Jan
|
