[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 4/4] arm/new vgic: Add ITS support to NEW_VGIC
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Thu, 26 Oct 2023 10:01:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U9YFE75pw8/VAWAThuBbllni+dqgf/ZdZaW5cUijMn0=; b=C9BuQtvFiYrHXDKvwiwIvSGMxVXKl0Jpw9IjB0z05u/3Pa8TJS4G/ErQ5Rqd8FfhTG1PHdlDiWirORanSpv4hNVsPJCByyBbNhYYxd/r6p7HI6e/mC4+EozfIH+1c0dZIC8IsVwW/MZmlq0ETUyJW/MkuAQUViy+eWiuz/KbrOPwPVtf2/PNn3PzdompGoX9Pgpg1YRippcLqmi8xD+eGQ97uikVBK+AptjoQ4qqhTfOG6u38MXDghLdToXy/Ne1Pz2sIOnsnTK+5IFZMbwclbonTkitwfZZWjcOQNvZe+YvSHG+Ctt6/ZuxysCE37h+wB8jraDIXIFIjCYI4P1Vnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPCEPtU3HYRsK6tSq3Te83o4XFQczCiaHN4HWTjhpeVKX3JZPEoo0rmQlyhEtCjkn/7N+bxIvpupXlD+CVN3Pzyxe4bqqlc1p66sC3ENox7u800Dgcv7baCgagBmE9mI4WX57A3MCIi7dFxuxBOQFb8L2CHiMFAQ1QrRzBFw12uxs/Oy5KG6EeCR3o5L0WDSWQDz74xq1GhTPCK+UApp+1DNjjX4+oKdAorqUPeDbk8dUfhh66SU6+ZJ0VEOE8BYuockdAMvWOIx3eInxXds46DIJPBwu5GimbBhcoJx8NN02zeLsoHJNQg6WGFrkp9fL0HKUYgF5GfiZiXemiqZ+g==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 26 Oct 2023 10:01:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaByVKOarKe67VpUmvAyf2tK5K3LBaTAOAgAGMbAA=
- Thread-topic: [XEN PATCH 4/4] arm/new vgic: Add ITS support to NEW_VGIC
Hi Julien,
On 25.10.23 13:22, Julien Grall wrote:
> Looking at the change, you mainly add #ifdef in the code. The goal of
> gic-v3-lpi.c was to be agnostic from the different vGIC. So please
> abstract it.
Would it be okay to add something like "typedef struct vgic_irq
pending_irq" to deal with the type differences or is it better to
completely move the code that mentions them into vgic files?
Regards,
Mykyta
|
