[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU][PATCHv2 1/8] xen: when unplugging emulated devices skip virtio devices
- To: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Thu, 26 Oct 2023 10:13:12 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgRssnI/fojT3LhdHgfivKq3kQildm1/kX+trC4wVIA=; b=Nidju6G+Jc6Hrimm7xarbL83Ren4HK4qpkjiq/PGtDb6qNrMbQG1LPyxeQ8YLWystQOUeefXERiPeDu3KHpbovbVg0ohWrIXSZudu3CjGbWWuwnl9mf2kVxVhAuJJ3bYaHlLIJPdYmxHr6L8aA99COkLRWKTpk8xyOtOvc1NHhqyvl6bWn/l/ujo+f8rQ9WwOiBLkSfh1S9VBzn80bQOPCD0/u1grmrYigpaSZYohViy6Po91E+5d17GNfq0DHNslXTCW3JaoSU1VqXTWmVAkxw4B5b/uZr/HLEVM6B+VphQnzPPA0bEbaWh0Hk0fe4a4IywybJN3/DUsYdc6vv4GQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AtuAT8B3hrQ4hdiRs1D3LZSl6I4UvlP4TUbRP7d56FOpR0q4qR8CCjDGer3O5klKZbrMYa1xnVGh3qT/GAUft0FnKgvhLmtXPRvy78F6uYyHKkGYFIYiEuLSSVDy7DJ46PGU5kBxyycMLlZCske73KsypDMEVXnnoYxAy7fpSbOCiGqdQ2X6wbSLgfU4YGHHgygt9ifUwN0pVi7+/FaTaTFX771IF+q6SMjC+IpOyFtK4NAwiBcUCgZn7CNPogyVuztVMs/+AoLA9wM7VIQ5Xfl//0n8PyKQKbbhjXupHIuYXEwEpdTE2kxyV/1KVqr1jiyUjSfWZTXs5j/QOLKTFQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, jgross@xxxxxxxx, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 26 Oct 2023 17:13:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Oct 26, 2023 at 04:45:21PM +0100, David Woodhouse wrote:
> On Wed, 2023-10-25 at 18:23 -0700, Stefano Stabellini wrote:
> > On Thu, 26 Oct 2023, David Woodhouse wrote:
> > > On Wed, 2023-10-25 at 14:24 -0700, Vikram Garhwal wrote:
> > > > From: Juergen Gross <jgross@xxxxxxxx>
> > > >
> > > > Virtio devices should never be unplugged at boot time, as they are
> > > > similar to pci passthrough devices.
> > > >
> > > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > > > Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> > >
> > > Hm, do your virtio NICs still actually *work* after that? Or are they
> > > all disconnected from their netdev peers?
> > >
> > > I suspect you're going to want a variant of
> > > https://lore.kernel.org/qemu-devel/20231025145042.627381-19-dwmw2@xxxxxxxxxxxxx/T/#u
> > > which also leave the peers of your virtio devices intact?
> >
> > Hi David, device unplug is an x86-only thing (see the definition of
> > xen_emul_unplug in Linux under arch/x86/xen/platform-pci-unplug.c) I
> > suspect Vikram who is working on ARM hasn't tested it.
>
> Ah, I had assumed there was something else coming along later which
> would make it actually get used.
>
> > Vikram, a simple option is to drop this patch if you don't need it.
>
> That works. Although I may revive it in that case.
>
Hopefully, Juergen is also okay with dropping the patch. Then, i will remove it
from v3.
Thanks David & Stefano!
|
