[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 13/28] hw/xen: automatically assign device index to block devices
On 27/10/2023 11:25, David Woodhouse wrote: On Fri, 2023-10-27 at 10:01 +0100, Durrant, Paul wrote:This code is allocating a name automatically so I think the onus is on it not create a needless clash which is likely to have unpredictable results depending on what the guest is. Just avoid any aliasing in the first place and things will be fine.Yeah, fair enough. In which case I'll probably switch to using xs_directory() and then processing those results to find a free slot, instead of going out to XenStore for every existence check. This isn't exactly fast path and I'm prepared to tolerate a little bit of O(n²), but only within reason :) Yes, doing an xs_directory() and then using the code xen_block_get_vdev() to populate a list of existent disks will be neater.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |