Re: [PATCH v2 2/2] x86/Kconfig: Introduce CONFIG_{AMD,INTEL} and conditionalise ucode

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Oct 27, 2023 at 09:12:40AM +0200, Jan Beulich wrote:
> On 26.10.2023 22:55, Andrew Cooper wrote:
> > We eventually want to be able to build a stripped down Xen for a single
> > platform.  Make a start with CONFIG_{AMD,INTEL} (hidden behind EXPERT, but
> > available to randconfig), and adjust the microcode logic.
> > 
> > No practical change.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> > CC: Jan Beulich <JBeulich@xxxxxxxx>
> > CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > CC: Wei Liu <wl@xxxxxxx>
> > CC: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> > CC: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> > CC: Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>
> > 
> > I've intentionally ignored the other vendors for now.  They can be put into
> > Kconfig by whomever figures out the actual dependencies between their init
> > routines.
> > 
> > v2:
> >  * Tweak text
> 
> What about the indentation issues mentioned in reply to v1?
> 
> As to using un-amended AMD and INTEL - Roger, what's your view here?

I think it would be good to add a suffix, like we do for
{AMD,INTEL}_IOMMU options, and reserve the plain AMD and INTEL options
as platform/system level options that enable both VENDOR_{CPU,IOMMU}
sub options.

So yes, {INTEL,AMD}_CPU seems a good option.

Regards, Roger.