[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xenoprof: move asm/ include


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 30 Oct 2023 14:24:55 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RNh4ROXv79CnE2jtd3XjBPdvjNoTnh7ZaDC1XhyUUZo=; b=YFFeQYjeIzxeSQyk/Z0ga0aJismotuKQtc04iv7kzePRgvcfk1ULoSV8VVeRHjmERuiAXVPiuNeIip3+iOtVNfVhE1ZWgC2r9ncxvPb9mfnQDZVRwA2Ga/i/GsSSs6tR4FT/Jn4byJo/f7PiTzeNKiscCcWKgQ7+muUuADFXo2K7Jfv9SNzdZEDtlXhC3IeOcq+0iSfmr+IL7dfPFMCtkJ3II5wwuy7CDCDEnClnZL/svd2mLArkJk68c3Ss1GbvN2J0kP7h7vAD5W279Y96NHeIko2UMlrat6JVy6FvpWZF+X4z+R/nhdN8QrymTCfV2P4vXCD9TOPaYYOJIyHA6g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMPzl8IG0ZyPSFXID7fupXxqzpRvod9KdyDj1e5E4kAmkP4F/4h5BW8o391wwwWioqyavkEZtLL2PnQAzYRyrIDHSSRCuyJpSck59U8VRM0rnP8Uacp5IhHAWia6XWlGJBPaFpdqHO/hDy5/9w5TNzyfjquYfj3ppZfk82jFSRha5p2nt5tS5pqST54ODphmRucyrQ3oAX7XHv0kuHH2ftyEVBVElBaja3iVebuPAkHhkSaIPfkjHw4mAz22GaykcAwm+TmzMDlRTiE/SqFvCQZhEJrM7IRsYYmDmv9JbvJ1G2rl6xcfuU+wqoJOGRVQH8AfXzzOK3jL7K0TsStz+g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • Delivery-date: Mon, 30 Oct 2023 13:25:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.10.2023 14:19, Jan Beulich wrote:
> There's no need for xen/xenoprof.h to include the arch header when the
> respective config option is off. The only compensation needed is for
> svm.c to explicitly include the arch header instead of the common one
> (matching what vmx.c and traps.c do).
> 
> With that Arm's header can be deleted, and neither RISC-V nor PPC will
> need to introduce one.
> 
> While there also adjust and move the (prior) inclusion of inttypes.h.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/arm/include/asm/xenoprof.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -#ifndef __ASM_XENOPROF_H__
> -#define __ASM_XENOPROF_H__
> -
> -#endif /* __ASM_XENOPROF_H__ */
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */

First time that I notice a shortcoming in quilt that I would not have run
into if I used git: quilt can't express deletion of an empty file;
arch/ppc/include/asm/xenoprof.h wants deleting as well.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.