[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xenoprof: move asm/ include
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 30 Oct 2023 15:36:46 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gwr/EL4ijqwFB8uewRyhrarUhK0sfr5Bn6uvcIuLe7Q=; b=evdGVxYfCCU6TNpWpycKAgSrXBcU0J72MFezhGl0Hg5YxvZbnMQIlrTWUUTlBm7L7PTGWaIyRnQ0+Iw7QpI3KDCSt262KZT4Fe9dndyDMW9yEuOeQdtePSvdsCy/4Nf8tWzZ+J6YwuwJfL/rXPjQoYAqy1dmtPJ2Gd/zK5LF65ePNaebUbW/7bLLTkXXRGouwm+PlXpzJ1cMZWg3bgidxOtIG/GVRBvNRuyuzWNq7PAZoNAiy4Cch5WX/16MSgVDI2oksU1eVx2dl0rftE5qUrL8ODfMDMLUH8/Zzk9aEmdiCuKaS29LR1ZzKWV5z5mPdRa+OyQHPss9GVHGgUo1AA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gwr/EL4ijqwFB8uewRyhrarUhK0sfr5Bn6uvcIuLe7Q=; b=J3Umu5BSQIjTL+6O5efepmZE7yAbcdMNxFfaLZwLcM/g0sGEO2lQspFaSpSoy6xlTqXS4esEpX4sbfvSBWMwWWxQuFEq4iZWBE4ye52ObvM/buAPb0osn/wR0RhqykBQIfO58u2D9WcQ+Ef2c0IBGu1q2eTI61WxxX6+oyHTZ0Oe3kgvg19igoB9H+4txu5Bl7yLWlNqIoyH5CLZwVzm5vIzj7MiSW5K1JupQ6o7pKqFPLpWqxEw7byDoXV3oIawoI16MOxXi69hZhzZL/BSyCwYoGZqdI4n1/oXU4L7e3BLzvfOP13rGFdklUeT1rrGXqFUWlEpkhUwgrMcMrNVQg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NDDqJ2XqjafexZUO7PuQ4PRKWceemdqO3Wd2VSrtZ4DVHIOkGrweoc11c7KuCNBYeiuTIp4A9h87/LBU/SbaaAxZz20tCT3WWe6aI7ja4PT739XKdMb6JE8I/e2sTTegsZZXlOsalsOIfv5rJD+yAm5ks+R1iCXoGDM23oGP0BhM4nauFaaazhKpuyjs6VQJ+UrdfSVMk+5FIInmDGRffqmWymuC4Kt40mAh/8WN+OhG38ePSx6BdqUCMgtnrvoSlUYokJNXTBpXQ10Wg5hbhkcQaGP7SV/iCSOrsii4VCmg3ROnUE+FspTmkylh2e2Q/Lu/AmFIk3VSNFeu8XhmsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKX+XPa4U/1gcGrY5ydRBidQC7XCyzdydiLA+Jhi7jEK2F9SG823R8iChdLZghu6+pm6nikv2y1LIWb0VeHp4oTzEXZxhCzx0jfiYqMEY59D3cNq0GDg1VyO6Um8n5be+Dy+iCaCic/9Vpv0ijfK/fM57770ibZuDUgRUDA6dC7IhMt3p67KR8qmiGh+3sSNZXbb3CIrfo37QmFcOgaDRGkwexX5hrnaSqnm7fnGIzfHxUUhnVJSyEi05CsNbXFhjfUJMHbybO4CCMpD35D3JDWI8BNUs3GfuDR+wIrhaxj29VZi0GlOdzDVajzB4+8wXr+F0LrbSHu+i+JIomwyvA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 30 Oct 2023 15:37:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaCzO1xyz/ZGFYC0K8JSTClKiKnrBid1QA
- Thread-topic: [PATCH] xenoprof: move asm/ include
Hi Jan,
> On 30 Oct 2023, at 14:19, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> There's no need for xen/xenoprof.h to include the arch header when the
> respective config option is off. The only compensation needed is for
> svm.c to explicitly include the arch header instead of the common one
> (matching what vmx.c and traps.c do).
>
> With that Arm's header can be deleted, and neither RISC-V nor PPC will
> need to introduce one.
>
> While there also adjust and move the (prior) inclusion of inttypes.h.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Always nice to remove a useless empty file :-)
For the arm part:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> --- a/xen/arch/arm/include/asm/xenoprof.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -#ifndef __ASM_XENOPROF_H__
> -#define __ASM_XENOPROF_H__
> -
> -#endif /* __ASM_XENOPROF_H__ */
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -12,7 +12,6 @@
> #include <xen/lib.h>
> #include <xen/sched.h>
> #include <xen/trace.h>
> -#include <xen/xenoprof.h>
>
> #include <asm/amd.h>
> #include <asm/apic.h>
> @@ -38,6 +37,7 @@
> #include <asm/processor.h>
> #include <asm/p2m.h>
> #include <asm/x86_emulate.h>
> +#include <asm/xenoprof.h>
>
> #include <public/sched.h>
>
> --- a/xen/include/xen/xenoprof.h
> +++ b/xen/include/xen/xenoprof.h
> @@ -10,15 +10,15 @@
> #ifndef __XEN_XENOPROF_H__
> #define __XEN_XENOPROF_H__
>
> -#include <xen/inttypes.h>
> -#include <asm/xenoprof.h>
> -
> #define PMU_OWNER_NONE 0
> #define PMU_OWNER_XENOPROF 1
> #define PMU_OWNER_HVM 2
>
> #ifdef CONFIG_XENOPROF
>
> +#include <xen/stdint.h>
> +#include <asm/xenoprof.h>
> +
> struct domain;
> struct vcpu;
> struct cpu_user_regs;
|
