[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 6/8] x86/physdev: address violations of MISRA C:2012 Rule 8.2
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 30 Oct 2023 17:01:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahqQJthhHqeYtQzGfndnYtX3ZmHLkrUP2KSsGgJ9lfE=; b=SsrYaGJ2fXLMBmE6zLYB8CViKni/jpBZunCL1dTBy7JpEDcfqgNGk45O6FbHv/WPCRYZpcIM+J+y8ixdeFeufv5EIsNjdJ1MhmIYo0FsAGSfHRvPnpOQdM8D1TWY6GNUHV3J1CDlCgdQSZSHohiVjDG6AaCdBwZIb+K6ZFE0RI9zmXM1FK8h8k3UUeD2S2Od4FbXaDHYpOV4v9XIA4x5OmHNUIUPtTGz8i06Bj8XqHheY9v5MpUs8w6gyoPQZFLNsX3H1k4K7FwhaaT20mqwMAeEdQ8j+uHkR1svuxJpKTrojD49Ew6r4pRRmjyLiy27hWWh3Qt6XbBhNDtB8PN57Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V1mh2uMZu63F1rt9aKuMyb2H2gMn76Y7DPjOjJoEkzjTtG3r/jdvF0EfIuJ1Y7cib7jl+s7Qh29eW74f+7ffYG+rdtSQJ/k3wMtCkaw3iKxYj0HtZY73A7Ya2TAhgBV0lyeHV1h/WptwH/Vst4zU9ia/L0tHE2hZY6MWvVYkySM27JGSxfSqpRghNzAe0614/c+cjYoY4n6rr46jNrRS+Ae4vvwW7kMeEB+cmwmHQBMvf0KyPE68W5+DfgC7ILXKV5KVucpV52dgAEZzj0dp3HlVAr0ezwhqQg+W6Jq3C4e7+caAaiX4ztpNQ8wLkFmBc3twzvRjUOg7kY/aDoNC9A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 30 Oct 2023 16:01:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 09:23, Federico Serafini wrote:
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Albeit I can't resist to say that ...
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -18,9 +18,9 @@
> #include <xsm/xsm.h>
> #include <asm/p2m.h>
>
> -int physdev_map_pirq(domid_t, int type, int *index, int *pirq_p,
> - struct msi_info *);
> -int physdev_unmap_pirq(domid_t, int pirq);
> +int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p,
> + struct msi_info *msi);
> +int physdev_unmap_pirq(domid_t domid, int pirq);
... this is a good example where adding names to the so far unnamed parameters
adds no new useful information at all, as their types were already sufficient
to express all that needs expressing here.
Jan
|
