[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/5] [FUTURE] xen/arm: enable vPCI for domUs
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 31 Oct 2023 12:03:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ri6wTvhU61+dtPiVZoj8WKX52jYX/xNXRDnRmks28bQ=; b=MOhkcpCywjldCmYZuSNMi3wUffFFFZ0QMcWhkr2cAdKsJerN6HsA9c2w/99u8eQKmUG7mWF1WZtjUCKXMqhdjXYDl0GR1bQ19du5HH+yGrwa/qAgma5MjVzQQb7Csr7GJg5ZzjIoFz+g2fVxkkvmap0Xjud30MEWlKgKeVa+98OYIgOUJRoWoq8pUhKuX93ebPbea3La1W1ceCKtXcTl/MxsROdbHcMxVZgx6o6ouOoVMAMXtvDKXOifptcBC6tS6hAbTBughTs5Bij/0G6t1RCx0kUwv+bm2LxFxZSSpvzurgjvE0Iixk8/hEKs77XuK+mNVc0AJkW2K3bsMoAxSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLHuHyzRQCoKkOtrWQCGX/1QE1HTxUqmEWxKy86eT8scr1b1s7mJ5TTRu6FsRNUVeL+lzl3N8mitJMg78dD2c/lMLRAtE0GrW63MNcNdkfjy4PowgHa8j+XFg9EM1oPxCqukkHwiB4Lh7AxvBpy0Hcia1OlWYdAxkeWJ78QDvP7hNtwkNvqnC2r72PdSYDe7JvMD/DJ/XPsJ2NGEwBSclX54D9bOnrARHNKA8bOslz6NILpD0NTVYsyaCHPD31TJWzQzsUPJSXGPlO11W1DiaYSZGZ9midguo1302eiV3m/Bh/D2sYrIeHfVT7hyZIkVlKSOMRQCukemLZNVtmBFEQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 31 Oct 2023 11:04:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.10.2023 00:52, Stewart Hildebrand wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1618,6 +1618,16 @@ int iommu_do_pci_domctl(
> bus = PCI_BUS(machine_sbdf);
> devfn = PCI_DEVFN(machine_sbdf);
>
> + if ( IS_ENABLED(CONFIG_ARM) &&
> + !is_hardware_domain(d) &&
> + !is_system_domain(d) &&
> + (!IS_ENABLED(CONFIG_HAS_VPCI_GUEST_SUPPORT) || !has_vpci(d)) )
I don't think you need the explicit ARM check; that's redundant with
checking !HAS_VPCI_GUEST_SUPPORT. It's also not really clear why you
need to check for the system domain here.
> + {
> + printk(XENLOG_G_WARNING "Cannot assign %pp to %pd: vPCI support
> not enabled\n",
> + &PCI_SBDF(seg, bus, devfn), d);
ret = -EPERM;
(or some other suitable error indicator)
Jan
> + break;
> + }
> +
> pcidevs_lock();
> ret = device_assigned(seg, bus, devfn);
> if ( domctl->cmd == XEN_DOMCTL_test_assign_device )
|
