[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: simplify clean handling of extras directory


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 2 Nov 2023 10:25:37 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpKVAJ0upb/h0b0UPw4xd9V6S+MqK9+HvGxKqgSlViA=; b=I50DOWqLpSUGDsZNwY/piLvMzT5AO07pVfprvpIKxB1XRAMgQK6dhwndNyJOWt7jHrGYUFkxOG1wFYV3zB3U0GxpB4W3GLmPnd0Lf0L1S8fg1+AomGwqqnG3Zv5lPNV/iTp5KSqRv7bljCV9AaFCV4pAWQH0EKcRDUdAHuoUP7ZMo3LqQKzK8IcZyTaWYTY0k3RaYXg1F9rKIhZpPfThxreGm2G9YPPjnoFC3SHQeJ0SdGszMmknZPCre2fOA/Pjy2OnNZLy0SqroMKRRjr7uLzDI9hnYGAXGWCFaDiODK/k+7yuhau/Dor6BcMGnYPTKNFf+MqVPq6pK2fjM+Ywcw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CB5u89L6ySFYnMVkFbPSW4SNfTjgp78qRsV3qlyPXe5ioXB7T1HEUb6GAWjHhBwhc4QJD2gXGxfYpOvNHjw/rbfgo44vhSHiPK3GjcpiWmWk4Nn37fLNAEKYQJWOX2opt/zPz6ew5g/LRWuZCVh8Mj68sI6SR6wufxON62q28X6E1Iavlp67euSyhim2sWAkTLKbgz8YYLTMCqD/jULCBrZL0y19muKTnz894NcBKGDo/wLIVhk29i4upQQs/NtquqlYJDiyppYaZMY1FSkxmNs7HPuKxMsxkx0ULgTC+r0Kv7UQePy644QfG6ABbuYD04bX6auYoSiMfrChyvlNGA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 02 Nov 2023 09:25:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.08.2023 10:39, Juergen Gross wrote:
> The extras directory is used only as a download target for Mini-OS
> sources. Instead of special handling extras/mini-os* in .gitignore and
> the clean targets, just use extras for that purpose.
> 
> So add "extras" to .gitignore and remove it when doing a
> "make distclean".
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
of course with ...

> ---
>  .gitignore | 2 +-
>  .hgignore  | 6 +-----
>  Makefile   | 2 +-
>  3 files changed, 3 insertions(+), 7 deletions(-)

... the no longer applicable .hgignore hunk dropped.

> --- a/Makefile
> +++ b/Makefile
> @@ -246,6 +246,7 @@ clean-docs:
>  # clean, but blow away tarballs
>  .PHONY: distclean
>  distclean: $(TARGS_DISTCLEAN)
> +     rm -rf extras

I'd also be inclined to add a trailing / here, but I guess I'll better
leave the change untouched while committing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.