[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/lib: remove the overwrtitten string functions from x86 build
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 2 Nov 2023 11:27:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LMVskElm2zKUqZWBjYVOrRPqqXawdoZIw1Szx7bGes=; b=dAHbn2hoJjI8rhazAu1CjBAQtZ8pevERkLM5eu2Tt+edapj5A/sIP00dLtvbJIm+upc4c/6489WIXheIGuBWbX8sRPI59NKSzfSHRu/T6YOBaU7igM5CXnn7K7jXdrCfgTTfH4hS1Uq3n6bgch9A2IXPG9udUGX2XckJUy5yhZjfkwtQWmQdZ81nNj4B50lHg3QqxlCRdadRQlhMSik/4cdQSGeSjPOSNTNRz4VWhYvGhsUuppys9bQkw3RIVloRw0Fhp/7M3F5Y1AyUdrIrqYbIi4trHdDf4T2Tq7ZhvsoAtdPGC1OgJb5069bcMXkpSjf5L6G7zrzpG1fKgSUY2A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+9CQx+GMV7Ou1WrSbWglI9eEwfPCNzndfmyta7R3AtI5RQ/scl4hONqt8g4Y6+zAN7PkxeggGe+Bi+7vPIFmuJMsf1VZDHE/6hqRjZIiU/rUliSwMkU4hXznfsMwKO0yErjS2nJHUQNfeFqXragVBbWRshcOSy1LrS0XG50y6YWzXSSA1Su3Vapot/jZnop9udHMQA6J2Zi045fRsir19i36JhTnLyDYsQdS5o+GOVFvFkqAFb8hikrE2IwITvuc6BFnEmq1tffdzEzTgSfqjMoOLYc3dkTtqKUJkOW+0SUMALHhZixxwa7QbItNlJFTPLI4IXmN56/0daPvdyu0w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 02 Nov 2023 10:27:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.11.2023 11:21, Federico Serafini wrote:
> Remove the generic implementation of memcpy(), memmove() and
> memset() from the x86 build since a version written in asm is present.
> This addesses violations of MISRA C:2012 Rule 8.6 ("An identifier with
> external linkage shall have exactly one external definition").
Yet part of the purpose of the code in lib/ is specifically to be available
as a (uniform) fallback. Nothing from the resulting lib.a is going to be
linked into the final Xen binaries, so I consider Eclair wrong (in some way
at least) to view such symbols as having multiple definitions.
Furthermore, if we really wanted to do conditional building like this, then
what to exclude would want to be determined dynamically, such that it won't
be necessary to keep two (or more) pieces of code in sync.
Jan
|
