[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen/lib: remove the overwrtitten string functions from x86 build



On Thu, 2 Nov 2023, Andrew Cooper wrote:
> On 02/11/2023 10:21 am, Federico Serafini wrote:
> > Remove the generic implementation of memcpy(), memmove() and
> > memset() from the x86 build since a version written in asm is present.
> > This addesses violations of MISRA C:2012 Rule 8.6 ("An identifier with
> > external linkage shall have exactly one external definition").
> >
> > Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> 
> As I said on one of the previous calls, this is an error in analysis,
> not a bug in Xen.
> 
> The behaviour when linking a library is well defined by the toolchain. 
> Disassemble the final hypervisor and observe that there really is only
> one implementation, and it's always the arch-optimised version when both
> exist.

This is done automatically by linker, right? I am asking because I was
curious and searching through the build system but couldn't find a
specific place where the dropping of the lib implementation of things is
done.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.