Re: [PATCH for-4.18 0/2] golang: Binding fixes

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, Nov 6, 2023 at 6:52 AM George Dunlap <george.dunlap@xxxxxxxxx> wrote:
>
> On Fri, Nov 3, 2023 at 7:46 PM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
> >
> > These two patches refresh the bindings which have gone a little stale.
> > I used two separate patches since the XSA-443 one may want backporting.
>
> Thanks for these.  Out of curiosity, do you use the golang bindings,
> and if so, are you happy with how you're consuming them now?  We had
> talked at some point about exposing the bindings somewhere on xenbits
> (or maybe gitlab) such that people should simply add the path to their
> golang projects and have it download & build like "normal".  Is that
> something you'd find useful?

Hi George,

No, I do not use the bindings, so I cannot answer your questions.  I
just noticed the bindings were stale when doing a rebase.

I think Andrew's idea to check these via gitlab is a good one.  They
seem to often be missed.  I only noticed because I had installed go,
and I only installed go to check binding generation for a previous
patch series.

Since the bindings are auto generated, do they really need to be
checked into the tree?  If gitlab checks their generation, then maybe
they don't need to be checked in?

Regards,
Jason