[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Remove all DECLARE_* op macros in xc
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 6 Nov 2023 14:54:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KnCVJruYxgBv2eG/1yjy9xmZRo9eW8MY0BXa4erKkTU=; b=kwtUQV9+sOHvgWtIq4EejIfiNFkUyxLkUTql7MHtBq6lG4hMKnMQnrYw8VkjIbrHprRLcymiuMLz+5W+lzyIopaHKT+hG7zJNNeUtzMW9AWaaaxf41jc1ARvp64axQh3JI2UGCDDotoJCKQc+sdL2sz91NT9hXqJeUAZ9rofdY9NgB/qvH6OA3xIh0/90hG/PchcY8zNZ8N8bTB1DDOueq5zGCtj2xaxjWQriwnp3QegmcXxP4yExRmu+xFP6h3slcJSSjKxrMEkN0hg0agKZYiJiUgp5JlPvOqTCGGA8A2QxOdlkc2xkQUiX9l7aR1V+E2tKOrmsByqiuW1Vwj8fA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a38QHW4l31WwgpnZGchyuAgSV6AiJLsHtjAwas6Gw/8XFo4ixohC2z62dHIxtYhAXdDvQv34nk09p0RLvWnyCb+InicBGV+xBjKkMBmnOPtui6eBu7D0CW7+v0e8Yohi2phTqyJdVtlPRibGB5xY3l7mOdfAlR4CIXFGJEgojmGfICBTBCQpoeUm5UDj9oPpQEg2VFge6Osy0l3c5EIEMTYp40iEkEmMy1eb2s89vZUxnBqRbcVNcoZIRFLCjGWAoT2EpYzse+bnVaPJpIZ4TJNGfFuoeMmFd5h4Y2/OmgSSU5+f9OP6miW2X7ux71PEO7qBueUnJWhaUCuaUQERBw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Olaf Hering <olaf@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andcooper@xxxxxxxxx>
- Delivery-date: Mon, 06 Nov 2023 13:54:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.11.2023 14:13, Alejandro Vallejo wrote:
> On Mon, Nov 06, 2023 at 11:29:57AM +0000, Andrew Cooper wrote:
>> On 06/11/2023 10:58 am, Olaf Hering wrote:
>>> Mon, 6 Nov 2023 08:19:46 +0000 Alejandro Vallejo
>>> <alejandro.vallejo@xxxxxxxxx>:
>>>
>>>> + struct xen_sysctl sysctl = {0};
>>> What is that zero doing here? I think a plain {} will do it as well.
>>
>> Indeed. It needs to be {} and not {0} to compile on some obsolete but
>> still supported versions of GCC.
>>
>> ~Andrew
> I tried to find out what you're talking about and all I could find was:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36750
>
> I'm guessing we are already inhibiting that warning because grepping for
> {0} shows a bunch of uses of this pattern both in toolstack and the
> hypervisor. If this breaks something it's already broken.
But it depends on the nature of the structure / union whether old gcc
would have an issue here. Just seeing the pattern in some places doesn't
mean they're also fine to have elsewhere.
Jan
|
