[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/9] Revert "xen/arm: Add cmdline boot option "pci-passthrough = <boolean>""
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Mon, 6 Nov 2023 12:47:52 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cx8pDRogpcYqms54K2gsyznF472DXVcc//V/df7+vAk=; b=DePEPe7bTaQu5IUNQwXzxA9C8fz60Y968QKWYvs1P8WN08Y6CBJpY3cp4uTkoZ29YWS5L6CaMcT0Miovx04IbCcpKFKRAnxhdUpG0WAEFLTrwv7vKFVKfilu+D5TiTBOrFGEYIxU/d8umJn2wVQ5nZxJMQqgDoyxHJsSgvsntMZCsQILiYwiw5AM0yXdhI0cZGcJ4Z/rbo7niiYJAgSbCL6zl3a0SiBrkDTTGoBQsRM+HBZ8qym/8Esi0hkPJxOUxXPNWgx9yRPivAZKxN5kPCFyXhGUuQ4jGFehdKTK4M++WE7ak/D+PRv/hQPDk83D1Fg7hpZ+b/WEIk13WnbQvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6Okd9k2Bu+ub8rn5Fz9yMmBgchVsQHuAZrZIjFegV5oWeak/g9fdYd7dCRfkwDSQN/RmnSbjScqRNRHmisbholjogxNsExrugjGIlmX8PFSQ8HVytN4uXnclriM9FdBXw+AdXC98ri0fBaeTO/0qlBTvTTGsllO4MLVGMCp/UYBtUl2rJ3JDZ8tfyWJVWgaezDU/DvxdNbarVxLTHoen03fXRZ8hEMJ6eh2FsWQze0YA9FBOQRELm1J4mM6VHXmvaUR2vdAT8VTqW0qgXf49mGShPkBF49rNwlmXjqol9ulOgBXl3xZqWJvawm+ijccjQWIj1aexQ8T8jZih0/kMw==
- Cc: Rahul Singh <rahul.singh@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 06 Nov 2023 17:48:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/20/23 14:13, Julien Grall wrote:
> Hi,
>
> On 04/10/2023 15:55, Stewart Hildebrand wrote:
>> From: Rahul Singh <rahul.singh@xxxxxxx>
>>
>> This enables us to use IOMMU + PCI in dom0 without having to specify
>> "pci-passthrough=yes".
>
> IIRC, the goal was to also allow to easily disable PCI passthrough (IOW
> vPCI at boot time). How would you do that now?
Right, a full revert would not allow that. I'll drop this revert/patch.
Instead, allowing the PHYSDEVOP_pci_device_{add,remove} calls and
xen/arch/arm/pci/pci.c:pci_init() to succeed in case of pci-passthrough=no
looks like it'll work.
>
>>
>> This reverts commit 15517ed61f55be6039aedcc99720ee07c772ed44.
>
> Rahul's signed-off-by and yours are missing.
>
> Cheers,
>
> --
> Julien Grall
|
