[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 8/8] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 7 Nov 2023 02:07:40 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HjUbt3yVydKt5NlzW28pp2dnE/6FBLz/CH7IGL5o6aQ=; b=Wybez+s+M4LRAaMpK9oQqbcDnmWmZ1MZ8CXbo3kkRvEUVC4Rsjorex+wJ+oOvHVAljS41ylDv0KHY/wDxOvf4Q+JWBhKNI5K2zQlN51SIvwhHb3npKEi5mgKGqDQ+41q+KWcqeGvPDgLDBv6CjCv34re42oP/rq9rCkzh9hJvosBVWhnQsXXWMZ5FKOwNDdvnCQ5lJMepIn9P9CHwjb5AOb0XsU6iU+AKB7lPiY4GDf//1XmE3GXsk6FlZ+OwMsD8gl94AfdPOC0od1pSMGfzq1bsase8aiLl4OzpthLjximqcsrQXxwmbMMugPq6z2321V/6azv1xtCH83u6w2QAA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HjUbt3yVydKt5NlzW28pp2dnE/6FBLz/CH7IGL5o6aQ=; b=mpTIXlP+2raw7vjBbnB6iRPnBu4TindjvvG4kAcGO5kE4AOFNIbkT0Opp1RfdSRx6MIJ58arThsKV7hNSGfFG7dIU9tl062n/zXNX5ZS0NXr9Ns8BmB+UXdrUMq3A+RUg6HQVWzH3J1PWu++mzyRaiHozYFqrOveI1KyQMMDrF7Up71qshB9cgAkU4xdxlpo3Tj39/Bci6xM5bZynYUxOzoaKb6B77+83WJdoh+ieDnfjA44CRVPkK2X+3jsNGkFiG19/nwD/GZw/cWaEaRwgfiQiL3sCNKYVsdGUVig9kgSb6A+FVC1gbw4s5StuFTZP0AbYsC1zzs1w3DUE5LC6g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YN82b7fvQOJFIl02aSs2Lec4JL+Gt19mvXi98ps4JzEYyb1HUNGyctLggT6kryxdZ6046VA4Wln9NkKKpFRhjTZYuN6TwOMoFDFHN/9Eyt+17yJrTa+0B/IaCgxcaYSFPduZUTUirpkbn9Q68LvA/+thXvjmv1g03hauYvdhTYKj/d3f0jz2arkEVeqcLAhXyvHVGlkC5YNUGdIflgNMeo8E+C/APCVevHFKStQCjdHEJEN9BNyynD1XeQ2tNZ7M3Y2dO4mmmVciQ24RJ09ZtbC0ih2tBa48/mRYsNBdYFgfm/0VSQ781cTVDwDltuYfSoznytTPeW+uwcaFnL6iIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7+IAwS0cNmKTBOQO9rA5a6tvraSq5eQ5bg0nATPu9IBbsKCI5wwnsyCHq1IwkgBbP4WqkAGI0jkMuXaYdAHndiSoN2GL4rMO8ln51gFHx/taJWH5kpDH5f8lhiIHPxLJdn59wWLKZD2OTEJEONb2ph9Tl6syQqbBoMyUL93nNQvBT+1er4X08TLXCDBqHnggMcNzV6krWVr11E2a50nWTvEqmZ8813ccPblqLfG51wy9wXlOe9iJgKLI8iwDnJpj5LL1dn+HJJeYG5Z2D5FB/8gYy9s/zZ6qYAH6SC9A2BBmsZSmjvOMOAu5EcsLmwNn5qsvs0N3C2128z+vHgayQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Tue, 07 Nov 2023 02:08:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaBVa3sLk3IeHXfE+9kkvgtQfUTbBl2VsAgABkvgCAB1rXgIAAmrMA
- Thread-topic: [PATCH v8 8/8] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}
Hi Julien,
> On Nov 7, 2023, at 00:53, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> I think the series is now fully acked. But I will wait for 4.18 to be
>>> released before merging this series.
>> I think the third patch "xen/arm: Fold mmu_init_secondary_cpu() to head.S”
>> will need the
>> double check from your side :)
>
> Oh yes :).
>
>> Here is what I have locally, to save time I will just show the content here
>> for you to check,
>> and I will push it in the next few days:
>> commit ba72d6dc17fd7ce9a863b9e00b06b33c069c7641
>> Author: Henry Wang <Henry.Wang@xxxxxxx>
>> Date: Wed Aug 23 17:59:50 2023 +0800
>> xen/arm: Fold mmu_init_secondary_cpu() to head.S
>> Currently mmu_init_secondary_cpu() only enforces the page table
>> should not contain mapping that are both Writable and eXecutables
>> after boot. To ease the arch/arm/mm.c split work, fold this function
>> to head.S.
>> For arm32, the WXN bit cannot be set early because at the point when
>> the MMU is enabled, the page-tables may still contain mapping which
>> are writable and executable. Therefore, introduce an assembly macro
>> pt_enforce_wxn. The macro is called before secondary CPUs jumping
>> into the C world.
>> For arm64, set the SCTLR_Axx_ELx_WXN flag right when the MMU is
>> enabled. This would avoid the extra TLB flush and SCTLR dance.
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>> Co-authored-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>
> The commit message is clearer. Thanks! Feel free to add my tag for the next
> version:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thank you very much! I will send a v9 with all stuff sorted.
Note for myself is that this series should have some conflict with Leo’s series
for AVA, so
I should do a proper rebase based on the order of merging these two series.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
>
|
