[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH][for-4.19 v2] xen: replace occurrences of SAF-1-safe with asmlinkage attribute



Hi Nicola,

On 07/11/2023 10:30, Nicola Vetrini wrote:
The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced
by the asmlinkage pseudo-attribute, for the sake of uniformity.

Add missing 'xen/compiler.h' #include-s where needed.

The text in docs/misra/deviations.rst and docs/misra/safe.json
is modified to reflect this change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>

With one note below:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

---
Changes in v2:
- Edit safe.json.
- Remove mention of SAF-1-safe in deviations.rst.
---
  docs/misra/deviations.rst   |  5 ++---
  docs/misra/safe.json        |  2 +-
  xen/arch/arm/cpuerrata.c    |  7 +++----
  xen/arch/arm/setup.c        |  5 ++---
  xen/arch/arm/smpboot.c      |  3 +--
  xen/arch/arm/traps.c        | 21 +++++++--------------
  xen/arch/x86/boot/cmdline.c |  5 +++--
  xen/arch/x86/boot/reloc.c   |  7 ++++---
  xen/arch/x86/extable.c      |  3 +--
  xen/arch/x86/setup.c        |  3 +--
  xen/arch/x86/traps.c        | 27 +++++++++------------------
  xen/common/efi/boot.c       |  5 ++---
  12 files changed, 36 insertions(+), 57 deletions(-)

diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst
index d468da2f5ce9..0fa0475db0eb 100644
--- a/docs/misra/deviations.rst
+++ b/docs/misra/deviations.rst
@@ -134,9 +134,8 @@ Deviations related to MISRA C:2012 Rules:
       - Tagged as `safe` for ECLAIR.
* - R8.4
-     - Functions and variables used only by asm modules are either marked with
-       the `asmlinkage` macro or with a SAF-1-safe textual deviation
-       (see safe.json).

This will require a rebase on top https://lore.kernel.org/all/b914ac93-2499-4bfd-a60a-51a9f1c170ec@xxxxxxx/ with the updated wording.

Also, it is a good idea to mention any dependency with any patches that are not yet in 'staging' (The for-next branch from Stefano doesn't count). This helps the committers to know which order the patches should be committed and also the reviewers to apply the patches for review.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.