[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2] tools: Remove all DECLARE_* op macros in xc
On Mon, Nov 06, 2023 at 01:25:29PM +0000, Alejandro Vallejo wrote: > These macros were hiding that the ops are not zero-initialized by the > toolstack. This is needlessly opaque for something so simple, so this patch > removes them and replaces them with explicit zero-initialising versions. > > The patch also removes PHYSDEV_OP from there, as that seems to be an old > dead macro. > > Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Thanks. Next step, reword some of those to read something like: struct xen_sysctl sysctl = { .cmd = XEN_SYSCTL_cpupool_op, .... }; which would look nicer :-) But that manual or for something like "coccinelle", so maybe one day. Cheers, -- Anthony PERARD
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |